Re: [PATCH v2 20/24] target/mips: Use decode_ase_msa() generated from decodetree

Richard Henderson
2020-12-16T00:07:37Z

On 12/15/20 4:57 PM, Philippe Mathieu-Daudé wrote:
> Now that we can decode the MSA ASE opcodes with decode_msa32(),
> use it and remove the unreachable code.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/mips/translate.h | 12 ------------
> target/mips/mod-msa_translate.c | 29 +----------------------------
> target/mips/translate.c | 31 ++++++++++---------------------
> 3 files changed, 11 insertions(+), 61 deletions(-)

Need an update to the comment after function name change?

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~