From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ADF8C433E6 for ; Tue, 5 Jan 2021 10:09:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D9F1A229C5 for ; Tue, 5 Jan 2021 10:09:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728076AbhAEKJd (ORCPT ); Tue, 5 Jan 2021 05:09:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:57060 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726171AbhAEKJd (ORCPT ); Tue, 5 Jan 2021 05:09:33 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2890C224F9; Tue, 5 Jan 2021 10:08:50 +0000 (UTC) Date: Tue, 5 Jan 2021 10:08:47 +0000 From: Catalin Marinas To: Keqian Zhu Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, Marc Zyngier , Will Deacon , Mark Rutland , Robin Murphy , Joerg Roedel , James Morse , Suzuki K Poulose , Julien Thierry , wanghaibin.wang@huawei.com Subject: Re: [PATCH] arm64/smp: Remove unused variable irq in arch_show_interrupts() Message-ID: <20210105100847.GB11802@gaia> References: <20210105092221.15144-1-zhukeqian1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210105092221.15144-1-zhukeqian1@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Jan 05, 2021 at 05:22:21PM +0800, Keqian Zhu wrote: > The local variable irq is added in commit a26388152531 ("arm64: > Remove custom IRQ stat accounting"), but forget to remove in > commit 5089bc51f81f ("arm64/smp: Use irq_desc_kstat_cpu() in > arch_show_interrupts()"). Just remove it. > > Signed-off-by: Keqian Zhu I already queued a similar fix in arm64 for-next/fixes (it should appear in linux-next at some point). -- Catalin