Re: [RESEND PATCH 2/2] KVM: X86: Expose bus lock debug exception to guest

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5378 bytes --]

Hi Chenyi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on kvm/linux-next]
[also build test ERROR on v5.11-rc2 next-20210108]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Chenyi-Qiang/Add-KVM-support-for-bus-lock-debug-exception/20210108-144848
base:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next
config: i386-randconfig-r015-20210108 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/fd0365cd4650a48a76379269b7cebd40ee38e52c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Chenyi-Qiang/Add-KVM-support-for-bus-lock-debug-exception/20210108-144848
        git checkout fd0365cd4650a48a76379269b7cebd40ee38e52c
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from arch/x86/kvm/cpuid.c:21:
   arch/x86/kvm/cpuid.c: In function 'kvm_set_cpu_caps':
>> arch/x86/kvm/cpuid.h:98:42: error: 'X86_FEATURE_BUS_LOCK_DETECT' undeclared (first use in this function); did you mean 'X86_FEATURE_SPLIT_LOCK_DETECT'?
      98 | #define feature_bit(name)  __feature_bit(X86_FEATURE_##name)
         |                                          ^~~~~~~~~~~~
   arch/x86/kvm/cpuid.c:55:11: note: in expansion of macro 'feature_bit'
      55 | #define F feature_bit
         |           ^~~~~~~~~~~
   arch/x86/kvm/cpuid.c:406:3: note: in expansion of macro 'F'
     406 |   F(BUS_LOCK_DETECT)
         |   ^
   arch/x86/kvm/cpuid.h:98:42: note: each undeclared identifier is reported only once for each function it appears in
      98 | #define feature_bit(name)  __feature_bit(X86_FEATURE_##name)
         |                                          ^~~~~~~~~~~~
   arch/x86/kvm/cpuid.c:55:11: note: in expansion of macro 'feature_bit'
      55 | #define F feature_bit
         |           ^~~~~~~~~~~
   arch/x86/kvm/cpuid.c:406:3: note: in expansion of macro 'F'
     406 |   F(BUS_LOCK_DETECT)
         |   ^
--
   In file included from include/linux/export.h:43,
                    from include/linux/linkage.h:7,
                    from include/linux/fs.h:5,
                    from include/linux/highmem.h:5,
                    from arch/x86/kvm/vmx/vmx.c:16:
   arch/x86/kvm/vmx/vmx.c: In function 'vmx_set_msr':
>> arch/x86/kvm/vmx/vmx.c:151:20: error: 'DEBUGCTLMSR_BUS_LOCK_DETECT' undeclared (first use in this function)
     151 |  DEBUGCTLMSR_BTF | DEBUGCTLMSR_BUS_LOCK_DETECT)
         |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
      58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
         |                                                    ^~~~
   arch/x86/kvm/vmx/vmx.c:2011:3: note: in expansion of macro 'if'
    2011 |   if (data & ~MSR_VMX_SUPPORTED_DEBUGCTL)
         |   ^~
   arch/x86/kvm/vmx/vmx.c:2011:15: note: in expansion of macro 'MSR_VMX_SUPPORTED_DEBUGCTL'
    2011 |   if (data & ~MSR_VMX_SUPPORTED_DEBUGCTL)
         |               ^~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/x86/kvm/vmx/vmx.c:151:20: note: each undeclared identifier is reported only once for each function it appears in
     151 |  DEBUGCTLMSR_BTF | DEBUGCTLMSR_BUS_LOCK_DETECT)
         |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
      58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
         |                                                    ^~~~
   arch/x86/kvm/vmx/vmx.c:2011:3: note: in expansion of macro 'if'
    2011 |   if (data & ~MSR_VMX_SUPPORTED_DEBUGCTL)
         |   ^~
   arch/x86/kvm/vmx/vmx.c:2011:15: note: in expansion of macro 'MSR_VMX_SUPPORTED_DEBUGCTL'
    2011 |   if (data & ~MSR_VMX_SUPPORTED_DEBUGCTL)
         |               ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> arch/x86/kvm/vmx/vmx.c:2016:30: error: 'X86_FEATURE_BUS_LOCK_DETECT' undeclared (first use in this function); did you mean 'X86_FEATURE_SPLIT_LOCK_DETECT'?
    2016 |       !guest_cpuid_has(vcpu, X86_FEATURE_BUS_LOCK_DETECT))
         |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
      58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
         |                                                    ^~~~
   arch/x86/kvm/vmx/vmx.c:2014:3: note: in expansion of macro 'if'
    2014 |   if (!msr_info->host_initiated &&
         |   ^~


vim +98 arch/x86/kvm/cpuid.h

a0a2260c12d8658 Sean Christopherson 2019-12-17  97  
87382003e355592 Sean Christopherson 2019-12-17 @98  #define feature_bit(name)  __feature_bit(X86_FEATURE_##name)
87382003e355592 Sean Christopherson 2019-12-17  99  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32672 bytes --]