Re: [kvm-unit-tests PATCH v4 4/9] s390x: Split assembly into multiple files

Cornelia Huck
2021-01-13T11:06:35Z

On Tue, 12 Jan 2021 08:20:49 -0500
Janosch Frank <frankja@linux.ibm.com> wrote:

> I've added too much to cstart64.S which is not start related
> already. Now that I want to add even more code it's time to split
> cstart64.S. lib.S has functions that are used in tests. macros.S
> contains macros which are used in cstart64.S and lib.S
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> Acked-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> ---
> s390x/Makefile | 6 +--
> s390x/cstart64.S | 119 ++---------------------------------------------
> s390x/lib.S | 65 ++++++++++++++++++++++++++
> s390x/macros.S | 77 ++++++++++++++++++++++++++++++
> 4 files changed, 149 insertions(+), 118 deletions(-)
> create mode 100644 s390x/lib.S
> create mode 100644 s390x/macros.S

Acked-by: Cornelia Huck <cohuck@redhat.com>