Re: [kvm-unit-tests PATCH v4 4/9] s390x: Split assembly into multiple files

Janosch Frank
2021-01-13T12:16:35Z

On 1/13/21 1:04 PM, Thomas Huth wrote:
> On 12/01/2021 14.20, Janosch Frank wrote:
>> I've added too much to cstart64.S which is not start related
>> already. Now that I want to add even more code it's time to split
>> cstart64.S. lib.S has functions that are used in tests. macros.S
>> contains macros which are used in cstart64.S and lib.S
>>
>> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
>> Acked-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
>> ---
>> s390x/Makefile | 6 +--
>> s390x/cstart64.S | 119 ++---------------------------------------------
>> s390x/lib.S | 65 ++++++++++++++++++++++++++
>
> lib.S is a very generic name ... maybe rather use cpuasm.S or something similar?

instr.S ?
Or maybe entry.S to make it similar to the kernel?

>
> Anway,
> Acked-by: Thomas Huth <thuth@redhat.com>
>

Thanks