Re: [kvm-unit-tests PATCH v4 5/9] s390x: sie: Add SIE to lib

Janosch Frank
2021-01-13T13:36:07Z

On 1/13/21 1:44 PM, Thomas Huth wrote:
> On 12/01/2021 14.20, Janosch Frank wrote:
>> This commit adds the definition of the SIE control block struct and
>> the assembly to execute SIE and save/restore guest registers.
>>
>> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
>> ---
>> lib/s390x/asm-offsets.c | 11 +++
>> lib/s390x/asm/arch_def.h | 9 ++
>> lib/s390x/interrupt.c | 7 ++
>> lib/s390x/sie.h | 197 +++++++++++++++++++++++++++++++++++++++
>> s390x/lib.S | 56 +++++++++++
>> 5 files changed, 280 insertions(+)
>> create mode 100644 lib/s390x/sie.h
> [...]
>> diff --git a/lib/s390x/sie.h b/lib/s390x/sie.h
>> new file mode 100644
>> index 0000000..66aa3b8
>> --- /dev/null
>> +++ b/lib/s390x/sie.h
>> @@ -0,0 +1,197 @@
>> +#ifndef SIE_H
>> +#define SIE_H
>
> Add a SPDX license identifier at the top of the new file?

Will do

>
> Apart from that looks ok to me.
>
> Acked-by: Thomas Huth <thuth@redhat.com>

Thanks!