Re: [PATCH v7 07/13] confidential guest support: Introduce cgs "ready" flag

Cornelia Huck
2021-01-15T13:13:54Z

On Thu, 14 Jan 2021 10:58:05 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:

> The platform specific details of mechanisms for implementing
> confidential guest support may require setup at various points during
> initialization. Thus, it's not really feasible to have a single cgs
> initialization hook, but instead each mechanism needs its own
> initialization calls in arch or machine specific code.
>
> However, to make it harder to have a bug where a mechanism isn't
> properly initialized under some circumstances, we want to have a
> common place, relatively late in boot, where we verify that cgs has
> been initialized if it was requested.
>
> This patch introduces a ready flag to the ConfidentialGuestSupport
> base type to accomplish this, which we verify just before the machine
> specific initialization function.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> hw/core/machine.c | 8 ++++++++
> include/exec/confidential-guest-support.h | 2 ++
> target/i386/sev.c | 2 ++
> 3 files changed, 12 insertions(+)

Reviewed-by: Cornelia Huck <cohuck@redhat.com>