Re: [PATCH v7 13/13] s390: Recognize confidential-guest-support option

David Gibson
2021-01-14T11:47:09Z

[-- Attachment #1: Type: text/plain, Size: 1009 bytes --]

On Thu, Jan 14, 2021 at 10:10:02AM +0100, Christian Borntraeger wrote:
>
>
> On 14.01.21 00:58, David Gibson wrote:
> [...]
> > +int s390_pv_init(ConfidentialGuestSupport *cgs, Error **errp)
> > +{
> > + if (!object_dynamic_cast(OBJECT(cgs), TYPE_S390_PV_GUEST)) {
> > + return 0;
> > + }
> > +
> > + if (!s390_has_feat(S390_FEAT_UNPACK)) {
> > + error_setg(errp,
> > + "CPU model does not support Protected Virtualization");
> > + return -1;
> > + }
>
> I am triggering this and I guess this is because the cpu model is not yet initialized at
> this point in time.

Bother. I thought I'd put the s390_pv_init() call late enough to
avoid that, but I guess not. Any chance you can debug that? Working
on s390 is far from easy for me.

--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]