Re: [kvm-unit-tests PATCH v1 1/5] s390x: css: Store CSS Characteristics

Pierre Morel
2021-02-01T12:10:48Z

On 2/1/21 11:01 AM, Janosch Frank wrote:
> On 1/29/21 3:34 PM, Pierre Morel wrote:
>> CSS characteristics exposes the features of the Channel SubSystem.

...

>> +/* Store Channel Subsystem Characteristics */
>> +struct chsc_scsc {
>> + struct chsc_header req;
>> + u32 reserved1;
>> + u32 reserved2;
>> + u32 reserved3;
>
> Array?

OK

...snip...

>> +int get_chsc_scsc(void)
>> +{
>> + int i, n;
>> + int ret = 0;
>> + char buffer[510];
>> + char *p;
>> +
>> + report_prefix_push("Channel Subsystem Call");
>> +
>> + if (chsc_scsc) {
>> + report_info("chsc_scsc already initialized");
>> + goto end;
>> + }
>> +
>> + chsc_scsc = alloc_pages(0);
>
> alloc_page() ?

OK too

Thanks for the comments,
Regards,
Pierre

--
Pierre Morel
IBM Lab Boeblingen