From: Thomas Huth <thuth@redhat.com>
To: kvm@vger.kernel.org, Janosch Frank <frankja@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, David Hildenbrand <david@redhat.com>,
Cornelia Huck <cohuck@redhat.com>
Subject: [kvm-unit-tests PATCH] Fix the length in the stsi check for the VM name
Date: Tue, 9 Feb 2021 16:57:05 +0100 [thread overview]
Message-ID: <20210209155705.67601-1-thuth@redhat.com> (raw)
sizeof(somepointer) results in the size of the pointer, i.e. 8 on a
64-bit system, so the
memcmp(data->ext_names[0], vm_name_ext, sizeof(vm_name_ext))
only compared the first 8 characters of the VM name here. Switch
to a proper array to get the sizeof() right.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
s390x/stsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/s390x/stsi.c b/s390x/stsi.c
index 4109b8d..87d4804 100644
--- a/s390x/stsi.c
+++ b/s390x/stsi.c
@@ -106,7 +106,7 @@ static void test_3_2_2(void)
0x00, 0x03 };
/* EBCDIC for "KVM/" */
const uint8_t cpi_kvm[] = { 0xd2, 0xe5, 0xd4, 0x61 };
- const char *vm_name_ext = "kvm-unit-test";
+ const char vm_name_ext[] = "kvm-unit-test";
struct stsi_322 *data = (void *)pagebuf;
report_prefix_push("3.2.2");
--
2.27.0
next reply other threads:[~2021-02-09 15:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 15:57 Thomas Huth [this message]
2021-02-09 16:55 ` [kvm-unit-tests PATCH] Fix the length in the stsi check for the VM name David Hildenbrand
2021-02-10 7:55 ` Janosch Frank
2021-02-10 11:05 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210209155705.67601-1-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox