From: Cornelia Huck <cohuck@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: kvm@vger.kernel.org, Janosch Frank <frankja@linux.ibm.com>,
linux-s390@vger.kernel.org, David Hildenbrand <david@redhat.com>
Subject: Re: [kvm-unit-tests PATCH] Fix the length in the stsi check for the VM name
Date: Wed, 10 Feb 2021 12:05:01 +0100 [thread overview]
Message-ID: <20210210120501.0e492991.cohuck@redhat.com> (raw)
In-Reply-To: <20210209155705.67601-1-thuth@redhat.com>
On Tue, 9 Feb 2021 16:57:05 +0100
Thomas Huth <thuth@redhat.com> wrote:
> sizeof(somepointer) results in the size of the pointer, i.e. 8 on a
> 64-bit system, so the
>
> memcmp(data->ext_names[0], vm_name_ext, sizeof(vm_name_ext))
>
> only compared the first 8 characters of the VM name here. Switch
> to a proper array to get the sizeof() right.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> s390x/stsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
prev parent reply other threads:[~2021-02-10 11:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 15:57 [kvm-unit-tests PATCH] Fix the length in the stsi check for the VM name Thomas Huth
2021-02-09 16:55 ` David Hildenbrand
2021-02-10 7:55 ` Janosch Frank
2021-02-10 11:05 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210120501.0e492991.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox