Re: [PATCH 0/7] hw/kvm: Exit gracefully when KVM is not supported

Peter Maydell
2021-02-19T11:57:19Z

On Fri, 19 Feb 2021 at 11:44, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> This series aims to improve user experience by providing
> a better error message when the user tries to enable KVM
> on machines not supporting it.

Thanks for having a look at this; fixing the ugly assertion
failure if you try to enable KVM for the raspi boards has
been vaguely on my todo list but never made it up to the top...

> Philippe Mathieu-Daudé (7):
> accel/kvm: Check MachineClass kvm_type() return value
> hw/boards: Introduce 'kvm_supported' field to MachineClass
> hw/arm: Set kvm_supported for KVM-compatible machines
> hw/mips: Set kvm_supported for KVM-compatible machines
> hw/ppc: Set kvm_supported for KVM-compatible machines
> hw/s390x: Set kvm_supported to s390-ccw-virtio machines
> accel/kvm: Exit gracefully when KVM is not supported

Don't we also need to set kvm_supported for the relevant
machine types in hw/i386 ?

thanks
-- PMM