Re: [PATCH 0/7] hw/kvm: Exit gracefully when KVM is not supported

Philippe Mathieu-Daudé
2021-02-19T12:11:08Z

On 2/19/21 12:55 PM, Peter Maydell wrote:
> On Fri, 19 Feb 2021 at 11:44, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>> This series aims to improve user experience by providing
>> a better error message when the user tries to enable KVM
>> on machines not supporting it.
>
> Thanks for having a look at this; fixing the ugly assertion
> failure if you try to enable KVM for the raspi boards has
> been vaguely on my todo list but never made it up to the top...

The other one annoying was the xlnx-zcu102 when creating
the Cortex-R cores.

>> Philippe Mathieu-Daudé (7):
>> accel/kvm: Check MachineClass kvm_type() return value
>> hw/boards: Introduce 'kvm_supported' field to MachineClass
>> hw/arm: Set kvm_supported for KVM-compatible machines
>> hw/mips: Set kvm_supported for KVM-compatible machines
>> hw/ppc: Set kvm_supported for KVM-compatible machines
>> hw/s390x: Set kvm_supported to s390-ccw-virtio machines
>> accel/kvm: Exit gracefully when KVM is not supported
>
> Don't we also need to set kvm_supported for the relevant
> machine types in hw/i386 ?

Lol, clearly a parapraxis =)

I'll send it as 8/7 until I get more review comments for a
v2 (in particular on the PPC patch):

-- >8 --
diff --git a/hw/i386/x86.c b/hw/i386/x86.c
index 6329f90ef90..da895aa051d 100644
--- a/hw/i386/x86.c
+++ b/hw/i386/x86.c
@@ -1218,6 +1218,7 @@ static void x86_machine_class_init(ObjectClass
*oc, void *data)
mc->cpu_index_to_instance_props = x86_cpu_index_to_props;
mc->get_default_cpu_node_id = x86_get_default_cpu_node_id;
mc->possible_cpu_arch_ids = x86_possible_cpu_arch_ids;
+ mc->kvm_supported = true;
x86mc->compat_apic_id_mode = false;
x86mc->save_tsc_khz = true;
nc->nmi_monitor_handler = x86_nmi;
---

Regards,

Phil.