Re: [PATCH 0/7] hw/kvm: Exit gracefully when KVM is not supported

Claudio Fontana
2021-02-19T12:35:30Z

On 2/19/21 12:44 PM, Philippe Mathieu-Daudé wrote:
> Hi,
>
> This series aims to improve user experience by providing
> a better error message when the user tries to enable KVM
> on machines not supporting it.
>
> Regards,
>
> Phil.

Hi Philippe, not sure if it fits in this series,

but also the experience of a user running on a machine with cortex-a72,
choosing that very same cpu with -cpu and then getting:

qemu-system-aarch64: kvm_init_vcpu: kvm_arch_init_vcpu failed (0): Invalid argument

is not super-friendly. Maybe some suggestion to use -cpu host with KVM could be good?

Thanks,

Claudio

>
> Philippe Mathieu-Daudé (7):
> accel/kvm: Check MachineClass kvm_type() return value
> hw/boards: Introduce 'kvm_supported' field to MachineClass
> hw/arm: Set kvm_supported for KVM-compatible machines
> hw/mips: Set kvm_supported for KVM-compatible machines
> hw/ppc: Set kvm_supported for KVM-compatible machines
> hw/s390x: Set kvm_supported to s390-ccw-virtio machines
> accel/kvm: Exit gracefully when KVM is not supported
>
> include/hw/boards.h | 6 +++++-
> accel/kvm/kvm-all.c | 12 ++++++++++++
> hw/arm/sbsa-ref.c | 1 +
> hw/arm/virt.c | 1 +
> hw/arm/xlnx-versal-virt.c | 1 +
> hw/mips/loongson3_virt.c | 1 +
> hw/mips/malta.c | 1 +
> hw/ppc/e500plat.c | 1 +
> hw/ppc/mac_newworld.c | 1 +
> hw/ppc/mac_oldworld.c | 1 +
> hw/ppc/mpc8544ds.c | 1 +
> hw/ppc/ppc440_bamboo.c | 1 +
> hw/ppc/prep.c | 1 +
> hw/ppc/sam460ex.c | 1 +
> hw/ppc/spapr.c | 1 +
> hw/s390x/s390-virtio-ccw.c | 1 +
> 16 files changed, 31 insertions(+), 1 deletion(-)
>