Re: [kvm-unit-tests PATCH v4 0/6] CSS Mesurement Block

[Cornelia Huck <cohuck@redhat.com>]

On Mon,  1 Mar 2021 12:46:59 +0100
Pierre Morel <pmorel@linux.ibm.com> wrote:

> We tests the update of the Mesurement Block (MB) format 0
> and format 1 using a serie of senseid requests.
> 
> *Warning*: One of the tests for format-1 will unexpectedly fail for QEMU elf
> unless the QEMU patch "css: SCHIB measurement block origin must be aligned"
> is applied.
> With Protected Virtualization, the PGM is correctly recognized.
> 
> The MB format 1 is only provided if the Extended mesurement Block
> feature is available.
> 
> This feature is exposed by the CSS characteristics general features
> stored by the Store Channel Subsystem Characteristics CHSC command,
> consequently, we implement the CHSC instruction call and the SCSC CHSC
> command.
> 
> In order to ease the writing of new tests using:
> - interrupt
> - enablement of a subchannel
> - multiple I/O on a subchannel
> 
> We do the following simplifications:
> - we create a CSS initialization routine
> - we register the I/O interrupt handler on CSS initialization
> - we do not enable or disable a subchannel in the senseid test,
>   assuming this test is done after the enable test, this allows
>   to create traffic using the SSCH used by senseid.
> - we add a css_enabled() function to test if a subchannel is enabled.
> 
> @Connie, I restructured the patches but I did not modify the
> functionalities, so I kept your R-B, I hope you are OK with this.

Yes, that's fine with me.

> 
> Regards,
> Pierre
> 
> Pierre Morel (6):
>   s390x: css: Store CSS Characteristics
>   s390x: css: simplifications of the tests
>   s390x: css: extending the subchannel modifying functions
>   s390x: css: implementing Set CHannel Monitor
>   s390x: css: testing measurement block format 0
>   s390x: css: testing measurement block format 1
> 
>  lib/s390x/css.h     | 116 +++++++++++++++++++++-
>  lib/s390x/css_lib.c | 232 +++++++++++++++++++++++++++++++++++++++++---
>  s390x/css.c         | 228 +++++++++++++++++++++++++++++++++++++++----
>  3 files changed, 542 insertions(+), 34 deletions(-)
>