From: Cornelia Huck <cohuck@redhat.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Alex Williamson <alex.williamson@redhat.com>, <kvm@vger.kernel.org>
Subject: Re: [PATCH] vfio: Depend on MMU
Date: Fri, 5 Mar 2021 09:46:49 +0100 [thread overview]
Message-ID: <20210305094649.25991311.cohuck@redhat.com> (raw)
In-Reply-To: <0-v1-02cb5500df6e+78-vfio_no_mmu_jgg@nvidia.com>
On Thu, 4 Mar 2021 21:30:03 -0400
Jason Gunthorpe <jgg@nvidia.com> wrote:
> VFIO_IOMMU_TYPE1 does not compile with !MMU:
>
> ../drivers/vfio/vfio_iommu_type1.c: In function 'follow_fault_pfn':
> ../drivers/vfio/vfio_iommu_type1.c:536:22: error: implicit declaration of function 'pte_write'; did you mean 'vfs_write'? [-Werror=implicit-function-declaration]
>
> So require it.
>
> Suggested-by: Cornelia Huck <cohuck@redhat.com>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
> drivers/vfio/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vfio/Kconfig b/drivers/vfio/Kconfig
> index 90c0525b1e0cf4..67d0bf4efa1606 100644
> --- a/drivers/vfio/Kconfig
> +++ b/drivers/vfio/Kconfig
> @@ -22,7 +22,7 @@ config VFIO_VIRQFD
> menuconfig VFIO
> tristate "VFIO Non-Privileged userspace driver framework"
> select IOMMU_API
> - select VFIO_IOMMU_TYPE1 if (X86 || S390 || ARM || ARM64)
> + select VFIO_IOMMU_TYPE1 if MMU && (X86 || S390 || ARM || ARM64)
> help
> VFIO provides a framework for secure userspace device drivers.
> See Documentation/driver-api/vfio.rst for more details.
Actually, I'm wondering how much sense vfio makes on !MMU at all? (And
maybe just merge this with your patch that switches IOMMU_API from a
depend to a select, because that is the change that makes the MMU
dependency required?)
next prev parent reply other threads:[~2021-03-05 8:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 1:30 [PATCH] vfio: Depend on MMU Jason Gunthorpe
2021-03-05 8:46 ` Cornelia Huck [this message]
2021-03-05 23:11 ` Jason Gunthorpe
2021-03-08 18:14 ` Cornelia Huck
2021-03-08 18:23 ` Jason Gunthorpe
2021-03-08 17:59 ` Alex Williamson
2021-03-08 18:12 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210305094649.25991311.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=jgg@nvidia.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox