Re: [PATCH 3/3] vDPA/ifcvf: bump version string to 1.0

Zhu, Lingshan
2021-03-08T02:41:25Z

Hi Leon,

Thanks for point this out, will send a V2 patchset delete it.

Thanks
Zhu Lingshan

On 3/7/2021 5:01 PM, Leon Romanovsky wrote:
> On Fri, Mar 05, 2021 at 10:20:00PM +0800, Zhu Lingshan wrote:
>> This commit bumps ifcvf driver version string to 1.0
>>
>> Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>
>> ---
>> drivers/vdpa/ifcvf/ifcvf_main.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c
>> index fd5befc5cbcc..56a0974cf93c 100644
>> --- a/drivers/vdpa/ifcvf/ifcvf_main.c
>> +++ b/drivers/vdpa/ifcvf/ifcvf_main.c
>> @@ -14,7 +14,7 @@
>> #include <linux/sysfs.h>
>> #include "ifcvf_base.h"
>>
>> -#define VERSION_STRING "0.1"
>> +#define VERSION_STRING "1.0"
> Please delete it instead of bumping it.
> We are not supposed to use in-kernel version for years already.
> https://lore.kernel.org/ksummit-discuss/20170625072423.GR1248@mtr-leonro.local/
>
> Thanks