From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A245C433DB for ; Thu, 25 Mar 2021 10:40:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C924B61A27 for ; Thu, 25 Mar 2021 10:40:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230220AbhCYKk3 (ORCPT ); Thu, 25 Mar 2021 06:40:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:33448 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229988AbhCYKkE (ORCPT ); Thu, 25 Mar 2021 06:40:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616668801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/kpD2aeNiHkluUl+lY5UKmHgOwXffwSQz+l4fa/jph4=; b=GmwtQNZ33xU9eqVbzpTARK59qsB5UjVZwZOJr3LlZFF3kZdVBeoScFOD6JKSsHr1wgfnPt pzXdqUvVLS9lxRlkJE0rh4Qriv1CtvDAlo3aFlwPV8vBrfn0PjNhlotX1oY29+muGtTPB0 kcbwATJ53g7EJ8/5ub1pnRN6lGA8G64= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-225-2Wj8hp4YPMi3tAZmsKefuw-1; Thu, 25 Mar 2021 06:39:55 -0400 X-MC-Unique: 2Wj8hp4YPMi3tAZmsKefuw-1 Received: by mail-wm1-f70.google.com with SMTP id o9so1086829wmq.9 for ; Thu, 25 Mar 2021 03:39:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/kpD2aeNiHkluUl+lY5UKmHgOwXffwSQz+l4fa/jph4=; b=uLk+mmq7lujLNyv5y/uCGcgKKHroVEZ8UhthAja3KJt195Y5pv6ImKIn6K2WB/9WQC jkisXJYfedeOc5Tv4f24B0U3/W6bIIu/9A+OVOayUbOhh+RF/m79iaM/Y3RrvNLmMPP2 zdXBqgHkYOP2rr4x+dCj5hsL4/W0xdTpWHqyt1YzJAbDbwk0LjD+7+Bsgm+gfMjOkfdJ 91Mbw7XTxVbXi9RVHK1zI/fchkZkj9bx+McfJtp7r5gc1F2WMH5XBxWcPcMvt568r0bR jJudFQcPoMWpF723Zqbh+oWvrORRi83zy8wfoFrLTdTC1gCbrc3P03CquG1+LmqyJF5Q PMXg== X-Gm-Message-State: AOAM533/iSsb3X8sB5vT0g/KdLFTYnfS4wUVeXFkXFcx8e7NA8YytlAh Eu24j1WBDMPKOCWzuuq4IyTzo+t4YyfOsbNKsNseroeHMmWPpNsXP/nCoKTO0KZPRH2tGkVNrLh DSVYPSMjNjMsk X-Received: by 2002:a5d:56d0:: with SMTP id m16mr8193219wrw.355.1616668793959; Thu, 25 Mar 2021 03:39:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxSTH23goWjAebsKh2RhkZfdPUdCAZpsy4s0EXvpQEhvBoOO6j7qufPnU+Ca8egdJ+gYncnng== X-Received: by 2002:a5d:56d0:: with SMTP id m16mr8193189wrw.355.1616668793779; Thu, 25 Mar 2021 03:39:53 -0700 (PDT) Received: from steredhat (host-79-34-249-199.business.telecomitalia.it. [79.34.249.199]) by smtp.gmail.com with ESMTPSA id c2sm6099603wmr.22.2021.03.25.03.39.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Mar 2021 03:39:53 -0700 (PDT) Date: Thu, 25 Mar 2021 11:39:50 +0100 From: Stefano Garzarella To: Arseny Krasnov Cc: Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , "David S. Miller" , Jakub Kicinski , Jorgen Hansen , Andra Paraschiv , Colin Ian King , Norbert Slusarek , Jeff Vander Stoep , Alexander Popov , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stsp2@yandex.ru, oxffffaa@gmail.com Subject: Re: [RFC PATCH v7 16/22] virtio/vsock: setup SEQPACKET ops for transport Message-ID: <20210325103950.7k75hntees5ppgbm@steredhat> References: <20210323130716.2459195-1-arseny.krasnov@kaspersky.com> <20210323131406.2461651-1-arseny.krasnov@kaspersky.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20210323131406.2461651-1-arseny.krasnov@kaspersky.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Mar 23, 2021 at 04:14:03PM +0300, Arseny Krasnov wrote: >This adds SEQPACKET ops for virtio transport and 'seqpacket_allow()' >callback. > >Signed-off-by: Arseny Krasnov >--- > net/vmw_vsock/virtio_transport.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) Sorry for not mentioning this in the previous review, but maybe we can merge this patch with "virtio/vsock: SEQPACKET feature bit support", so we have a single patch when we fully enable the SEQPACKET support in this transport. Anyway, I don't have a strong opinion on that. What do you think? Stefano > >diff --git a/net/vmw_vsock/virtio_transport.c >b/net/vmw_vsock/virtio_transport.c >index 2700a63ab095..83ae2078c847 100644 >--- a/net/vmw_vsock/virtio_transport.c >+++ b/net/vmw_vsock/virtio_transport.c >@@ -443,6 +443,8 @@ static void virtio_vsock_rx_done(struct virtqueue *vq) > queue_work(virtio_vsock_workqueue, &vsock->rx_work); > } > >+static bool virtio_transport_seqpacket_allow(void); >+ > static struct virtio_transport virtio_transport = { > .transport = { > .module = THIS_MODULE, >@@ -469,6 +471,10 @@ static struct virtio_transport virtio_transport = { > .stream_is_active = virtio_transport_stream_is_active, > .stream_allow = virtio_transport_stream_allow, > >+ .seqpacket_dequeue = virtio_transport_seqpacket_dequeue, >+ .seqpacket_enqueue = virtio_transport_seqpacket_enqueue, >+ .seqpacket_allow = virtio_transport_seqpacket_allow, >+ > .notify_poll_in = virtio_transport_notify_poll_in, > .notify_poll_out = virtio_transport_notify_poll_out, > .notify_recv_init = virtio_transport_notify_recv_init, >@@ -483,8 +489,14 @@ static struct virtio_transport virtio_transport = { > }, > > .send_pkt = virtio_transport_send_pkt, >+ .seqpacket_allow = false > }; > >+static bool virtio_transport_seqpacket_allow(void) >+{ >+ return virtio_transport.seqpacket_allow; >+} >+ > static void virtio_transport_rx_work(struct work_struct *work) > { > struct virtio_vsock *vsock = >-- 2.25.1 >