[PATCH] tools/kvm_stat: Add restart delay

[PATCH] tools/kvm_stat: Add restart delay

[Stefan Raspl]

If this service is enabled and the system rebooted, Systemd's initial
attempt to start this unit file may fail in case the kvm module is not
loaded. Since we did not specify a delay for the retries, Systemd
restarts with a minimum delay a number of times before giving up and
disabling the service. Which means a subsequent kvm module load will
have kvm running without monitoring.
Adding a delay to fix this.

Signed-off-by: Stefan Raspl <raspl@linux.ibm.com>
---
 tools/kvm/kvm_stat/kvm_stat.service | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/kvm/kvm_stat/kvm_stat.service b/tools/kvm/kvm_stat/kvm_stat.service
index 71aabaffe779..8f13b843d5b4 100644
--- a/tools/kvm/kvm_stat/kvm_stat.service
+++ b/tools/kvm/kvm_stat/kvm_stat.service
@@ -9,6 +9,7 @@ Type=simple
 ExecStart=/usr/bin/kvm_stat -dtcz -s 10 -L /var/log/kvm_stat.csv
 ExecReload=/bin/kill -HUP $MAINPID
 Restart=always
+RestartSec=60s
 SyslogIdentifier=kvm_stat
 SyslogLevel=debug
 
-- 
2.25.1

Re: [PATCH] tools/kvm_stat: Add restart delay

[Paolo Bonzini]

On 25/03/21 13:29, Stefan Raspl wrote:
> If this service is enabled and the system rebooted, Systemd's initial
> attempt to start this unit file may fail in case the kvm module is not
> loaded. Since we did not specify a delay for the retries, Systemd
> restarts with a minimum delay a number of times before giving up and
> disabling the service. Which means a subsequent kvm module load will
> have kvm running without monitoring.
> Adding a delay to fix this.
> 
> Signed-off-by: Stefan Raspl <raspl@linux.ibm.com>
> ---
>   tools/kvm/kvm_stat/kvm_stat.service | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tools/kvm/kvm_stat/kvm_stat.service b/tools/kvm/kvm_stat/kvm_stat.service
> index 71aabaffe779..8f13b843d5b4 100644
> --- a/tools/kvm/kvm_stat/kvm_stat.service
> +++ b/tools/kvm/kvm_stat/kvm_stat.service
> @@ -9,6 +9,7 @@ Type=simple
>   ExecStart=/usr/bin/kvm_stat -dtcz -s 10 -L /var/log/kvm_stat.csv
>   ExecReload=/bin/kill -HUP $MAINPID
>   Restart=always
> +RestartSec=60s
>   SyslogIdentifier=kvm_stat
>   SyslogLevel=debug
>   
> 

Queued, thanks.

Paolo