From: Cornelia Huck <cohuck@redhat.com>
To: Pierre Morel <pmorel@linux.ibm.com>
Cc: Thomas Huth <thuth@redhat.com>,
kvm@vger.kernel.org, frankja@linux.ibm.com, david@redhat.com,
imbrenda@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH v2 3/8] s390x: css: simplify skipping tests on no device
Date: Tue, 30 Mar 2021 13:52:50 +0200 [thread overview]
Message-ID: <20210330135250.00372e8e.cohuck@redhat.com> (raw)
In-Reply-To: <ce270f66-3d17-92d3-81d2-59fd9e0bd87f@linux.ibm.com>
On Mon, 29 Mar 2021 14:50:22 +0200
Pierre Morel <pmorel@linux.ibm.com> wrote:
> On 3/29/21 10:19 AM, Thomas Huth wrote:
> > On 25/03/2021 10.39, Pierre Morel wrote:
> >> We will lhave to test if a device is present for every tests
> >> in the future.
> >> Let's provide a macro to check if the device is present and
> >> to skip the tests if it is not.
> >>
> >> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> >> ---
> >> s390x/css.c | 27 +++++++++++----------------
> >> 1 file changed, 11 insertions(+), 16 deletions(-)
> > I wonder whether it would be easier to simply skip all tests in main()
> > if the test device is not available, instead of checking it again and
> > again and again...?
> >
> > Thomas
> >
>
> I will silently skip the remaining tests when the enumeration fails or
> do you want that we see other information?
> It seems obvious enough that finding no device we do not continue testing.
Logging that the device enumeration failed should be enough info.
next prev parent reply other threads:[~2021-03-30 11:53 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 9:38 [kvm-unit-tests PATCH v2 0/8] Testing SSCH, CSCH and HSCH for errors Pierre Morel
2021-03-25 9:39 ` [kvm-unit-tests PATCH v2 1/8] s390x: lib: css: disabling a subchannel Pierre Morel
2021-03-25 14:52 ` Claudio Imbrenda
2021-03-25 16:10 ` Pierre Morel
2021-03-26 8:26 ` Janosch Frank
2021-03-26 9:02 ` Pierre Morel
2021-03-29 8:00 ` Thomas Huth
2021-03-29 12:33 ` Pierre Morel
2021-03-25 9:39 ` [kvm-unit-tests PATCH v2 2/8] s390x: lib: css: SCSW bit definitions Pierre Morel
2021-03-25 15:00 ` Claudio Imbrenda
2021-03-25 16:13 ` Pierre Morel
2021-03-29 8:09 ` Thomas Huth
2021-03-29 12:25 ` Pierre Morel
2021-03-30 11:49 ` Cornelia Huck
2021-03-30 12:59 ` Pierre Morel
2021-03-25 9:39 ` [kvm-unit-tests PATCH v2 3/8] s390x: css: simplify skipping tests on no device Pierre Morel
2021-03-25 15:21 ` Claudio Imbrenda
2021-03-25 16:21 ` Pierre Morel
2021-03-26 8:41 ` Janosch Frank
2021-03-26 9:04 ` Pierre Morel
2021-03-29 8:19 ` Thomas Huth
2021-03-29 12:39 ` Pierre Morel
2021-03-29 12:50 ` Pierre Morel
2021-03-30 11:52 ` Cornelia Huck [this message]
2021-03-30 12:58 ` Pierre Morel
2021-03-25 9:39 ` [kvm-unit-tests PATCH v2 4/8] s390x: lib: css: separate wait for IRQ and check I/O completion Pierre Morel
2021-03-25 15:24 ` Claudio Imbrenda
2021-03-25 16:23 ` Pierre Morel
2021-03-29 8:21 ` Thomas Huth
2021-03-29 11:00 ` Pierre Morel
2021-03-30 11:57 ` Cornelia Huck
2021-03-30 12:57 ` Pierre Morel
2021-04-01 8:24 ` Pierre Morel
2021-03-25 9:39 ` [kvm-unit-tests PATCH v2 5/8] s390x: lib: css: add SCSW ctrl expectations to " Pierre Morel
2021-03-25 15:40 ` Claudio Imbrenda
2021-03-29 8:27 ` Thomas Huth
2021-03-29 8:32 ` Thomas Huth
2021-03-29 11:01 ` Pierre Morel
2021-03-29 11:02 ` Pierre Morel
2021-03-30 12:10 ` Cornelia Huck
2021-03-30 12:54 ` Pierre Morel
2021-03-25 9:39 ` [kvm-unit-tests PATCH v2 6/8] s390x: css: testing ssch error response Pierre Morel
2021-03-25 16:02 ` Claudio Imbrenda
2021-03-25 17:23 ` Pierre Morel
2021-03-26 10:41 ` Pierre Morel
2021-03-26 10:58 ` Claudio Imbrenda
2021-03-29 7:42 ` Pierre Morel
2021-03-30 13:01 ` Pierre Morel
2021-03-29 9:40 ` Pierre Morel
2021-03-25 9:39 ` [kvm-unit-tests PATCH v2 7/8] s390x: css: testing halt subchannel Pierre Morel
2021-03-25 9:39 ` [kvm-unit-tests PATCH v2 8/8] s390x: css: testing clear subchannel Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210330135250.00372e8e.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=pmorel@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox