From: Cornelia Huck <cohuck@redhat.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
kvm@vger.kernel.org, Kirti Wankhede <kwankhede@nvidia.com>,
linux-doc@vger.kernel.org, "Raj, Ashok" <ashok.raj@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Christoph Hellwig <hch@lst.de>,
Leon Romanovsky <leonro@nvidia.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>,
Tarun Gupta <targupta@nvidia.com>
Subject: Re: [PATCH 02/18] vfio/mdev: Add missing typesafety around mdev_device
Date: Tue, 30 Mar 2021 17:24:31 +0200 [thread overview]
Message-ID: <20210330172431.724282c1.cohuck@redhat.com> (raw)
In-Reply-To: <2-v1-7dedf20b2b75+4f785-vfio2_jgg@nvidia.com>
On Tue, 23 Mar 2021 14:55:19 -0300
Jason Gunthorpe <jgg@nvidia.com> wrote:
> The mdev API should accept and pass a 'struct mdev_device *' in all
> places, not pass a 'struct device *' and cast it internally with
> to_mdev_device(). Particularly in its struct mdev_driver functions, the
> whole point of a bus's struct device_driver wrapper is to provide type
> safety compared to the default struct device_driver.
>
> Further, the driver core standard is for bus drivers to expose their
> device structure in their public headers that can be used with
> container_of() inlines and '&foo->dev' to go between the class levels, and
> '&foo->dev' to be used with dev_err/etc driver core helper functions. Move
> 'struct mdev_device' to mdev.h
>
> Once done this allows moving some one instruction exported functions to
> static inlines, which in turns allows removing one of the two grotesque
> symbol_get()'s related to mdev in the core code.
>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
> .../driver-api/vfio-mediated-device.rst | 4 +-
> drivers/vfio/mdev/mdev_core.c | 64 ++-----------------
> drivers/vfio/mdev/mdev_driver.c | 4 +-
> drivers/vfio/mdev/mdev_private.h | 23 +------
> drivers/vfio/mdev/mdev_sysfs.c | 26 ++++----
> drivers/vfio/mdev/vfio_mdev.c | 7 +-
> drivers/vfio/vfio_iommu_type1.c | 25 ++------
> include/linux/mdev.h | 58 +++++++++++++----
> 8 files changed, 83 insertions(+), 128 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2021-03-30 15:25 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 17:55 [PATCH 00/18] Make vfio_mdev type safe Jason Gunthorpe
2021-03-23 17:55 ` [PATCH 01/18] vfio/mdev: Fix missing static's on MDEV_TYPE_ATTR's Jason Gunthorpe
2021-03-23 17:55 ` [PATCH 02/18] vfio/mdev: Add missing typesafety around mdev_device Jason Gunthorpe
2021-03-26 2:04 ` Tian, Kevin
2021-03-30 15:24 ` Cornelia Huck [this message]
2021-03-23 17:55 ` [PATCH 03/18] vfio/mdev: Simplify driver registration Jason Gunthorpe
2021-03-23 19:14 ` Christoph Hellwig
2021-03-26 12:10 ` Jason Gunthorpe
2021-03-26 12:55 ` Christoph Hellwig
2021-03-26 2:17 ` Tian, Kevin
2021-03-30 15:28 ` Cornelia Huck
2021-03-23 17:55 ` [PATCH 04/18] vfio/mdev: Use struct mdev_type in struct mdev_device Jason Gunthorpe
2021-03-23 19:15 ` Christoph Hellwig
2021-03-26 2:29 ` Tian, Kevin
2021-04-06 18:41 ` Jason Gunthorpe
2021-03-30 15:31 ` Cornelia Huck
2021-03-23 17:55 ` [PATCH 05/18] vfio/mdev: Do not allow a mdev_type to have a NULL parent pointer Jason Gunthorpe
2021-03-23 19:15 ` Christoph Hellwig
2021-04-06 16:08 ` Jason Gunthorpe
2021-03-26 2:38 ` Tian, Kevin
2021-03-29 8:42 ` Max Gurtovoy
2021-03-30 15:34 ` Cornelia Huck
2021-03-23 17:55 ` [PATCH 06/18] vfio/mdev: Expose mdev_get/put_parent to mdev_private.h Jason Gunthorpe
2021-03-23 19:16 ` Christoph Hellwig
2021-03-26 2:47 ` Tian, Kevin
2021-03-30 15:37 ` Cornelia Huck
2021-03-23 17:55 ` [PATCH 07/18] vfio/mdev: Add missing reference counting to mdev_type Jason Gunthorpe
2021-03-23 19:17 ` Christoph Hellwig
2021-03-26 2:52 ` Tian, Kevin
2021-03-30 15:38 ` Cornelia Huck
2021-03-23 17:55 ` [PATCH 08/18] vfio/mdev: Reorganize mdev_device_create() Jason Gunthorpe
2021-03-23 19:20 ` Christoph Hellwig
2021-03-26 3:33 ` Tian, Kevin
2021-03-26 3:36 ` Tian, Kevin
2021-04-06 16:40 ` Jason Gunthorpe
2021-03-26 3:31 ` Tian, Kevin
2021-03-30 15:50 ` Cornelia Huck
2021-03-23 17:55 ` [PATCH 09/18] vfio/mdev: Add missing error handling to dev_set_name() Jason Gunthorpe
2021-03-23 19:21 ` Christoph Hellwig
2021-03-26 3:35 ` Tian, Kevin
2021-03-29 8:50 ` Max Gurtovoy
2021-03-30 15:53 ` Cornelia Huck
2021-03-23 17:55 ` [PATCH 10/18] vfio/mdev: Remove duplicate storage of parent in mdev_device Jason Gunthorpe
2021-03-23 19:22 ` Christoph Hellwig
2021-03-26 3:53 ` Tian, Kevin
2021-03-26 11:53 ` Jason Gunthorpe
2021-03-30 16:14 ` Cornelia Huck
2021-03-30 16:50 ` Jason Gunthorpe
2021-03-30 16:15 ` Cornelia Huck
2021-03-23 17:55 ` [PATCH 11/18] vfio/mdev: Add mdev/mtype_get_type_group_id() Jason Gunthorpe
2021-03-23 19:23 ` Christoph Hellwig
2021-04-06 18:53 ` Jason Gunthorpe
2021-03-26 5:52 ` Tian, Kevin
2021-03-30 16:26 ` Cornelia Huck
2021-03-23 17:55 ` [PATCH 12/18] vfio/mtty: Use mdev_get_type_group_id() Jason Gunthorpe
2021-03-23 19:24 ` Christoph Hellwig
2021-03-23 17:55 ` [PATCH 13/18] vfio/mdpy: " Jason Gunthorpe
2021-03-23 19:25 ` Christoph Hellwig
2021-03-23 17:55 ` [PATCH 14/18] vfio/mbochs: " Jason Gunthorpe
2021-03-23 19:25 ` Christoph Hellwig
2021-03-23 17:55 ` [PATCH 17/18] vfio/mdev: Remove kobj from mdev_parent_ops->create() Jason Gunthorpe
2021-03-23 19:29 ` Christoph Hellwig
2021-03-26 6:11 ` Tian, Kevin
2021-03-30 16:29 ` Cornelia Huck
2021-03-23 17:55 ` [PATCH 18/18] vfio/mdev: Correct the function signatures for the mdev_type_attributes Jason Gunthorpe
2021-03-23 19:31 ` Christoph Hellwig
2021-04-06 18:34 ` Jason Gunthorpe
2021-03-26 7:03 ` Tian, Kevin
2021-03-30 16:35 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210330172431.724282c1.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=hch@lst.de \
--cc=jgg@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=mgurtovoy@nvidia.com \
--cc=targupta@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox