From: Max Gurtovoy <mgurtovoy@nvidia.com>
To: <mst@redhat.com>, <kvm@vger.kernel.org>,
<virtualization@lists.linux-foundation.org>,
<jasowang@redhat.com>
Cc: <oren@nvidia.com>, <nitzanc@nvidia.com>, <cohuck@redhat.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>
Subject: [PATCH v2 2/3] virito_pci: add timeout to reset device operation
Date: Thu, 8 Apr 2021 08:11:08 +0000 [thread overview]
Message-ID: <20210408081109.56537-2-mgurtovoy@nvidia.com> (raw)
In-Reply-To: <20210408081109.56537-1-mgurtovoy@nvidia.com>
According to the spec after writing 0 to device_status, the driver MUST
wait for a read of device_status to return 0 before reinitializing the
device. In case we have a device that won't return 0, the reset
operation will loop forever and cause the host/vm to stuck. Set timeout
for 3 minutes before giving up on the device.
Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
---
drivers/virtio/virtio_pci_modern.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_pci_modern.c b/drivers/virtio/virtio_pci_modern.c
index cc3412a96a17..dcee616e8d21 100644
--- a/drivers/virtio/virtio_pci_modern.c
+++ b/drivers/virtio/virtio_pci_modern.c
@@ -162,6 +162,7 @@ static int vp_reset(struct virtio_device *vdev)
{
struct virtio_pci_device *vp_dev = to_vp_device(vdev);
struct virtio_pci_modern_device *mdev = &vp_dev->mdev;
+ unsigned long timeout = jiffies + msecs_to_jiffies(180000);
/* 0 status means a reset. */
vp_modern_set_status(mdev, 0);
@@ -169,9 +170,16 @@ static int vp_reset(struct virtio_device *vdev)
* device_status to return 0 before reinitializing the device.
* This will flush out the status write, and flush in device writes,
* including MSI-X interrupts, if any.
+ * Set a timeout before giving up on the device.
*/
- while (vp_modern_get_status(mdev))
+ while (vp_modern_get_status(mdev)) {
+ if (time_after(jiffies, timeout)) {
+ dev_err(&vdev->dev, "virtio: device not ready. "
+ "Aborting. Try again later\n");
+ return -EAGAIN;
+ }
msleep(1);
+ }
/* Flush pending VQ/configuration callbacks. */
vp_synchronize_vectors(vdev);
return 0;
--
2.25.4
next prev parent reply other threads:[~2021-04-08 8:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 8:11 [PATCH v2 1/3] virtio: update reset callback to return status Max Gurtovoy
2021-04-08 8:11 ` Max Gurtovoy [this message]
2021-04-08 9:01 ` [PATCH v2 2/3] virito_pci: add timeout to reset device operation Jason Wang
2021-04-08 9:44 ` Max Gurtovoy
2021-04-08 12:45 ` Jason Wang
2021-04-08 12:57 ` Max Gurtovoy
2021-04-08 13:18 ` Jason Wang
2021-04-08 8:11 ` [PATCH v2 3/3] virtio_pci: add module param for reset_timeout Max Gurtovoy
2021-04-08 8:58 ` [PATCH v2 1/3] virtio: update reset callback to return status Jason Wang
2021-04-08 9:56 ` Max Gurtovoy
2021-04-08 13:14 ` Jason Wang
2021-04-08 14:24 ` Max Gurtovoy
2021-04-09 5:22 ` Jason Wang
2021-04-11 9:50 ` Max Gurtovoy
2021-04-12 9:07 ` Michael S. Tsirkin
2021-04-12 12:17 ` Max Gurtovoy
2021-04-12 21:29 ` Michael S. Tsirkin
2021-04-08 15:56 ` Michael S. Tsirkin
2021-04-12 11:55 ` Max Gurtovoy
2021-04-12 12:04 ` Michael S. Tsirkin
2021-04-12 13:03 ` Max Gurtovoy
2021-04-12 21:23 ` Michael S. Tsirkin
2021-04-12 22:53 ` Max Gurtovoy
2021-04-13 2:42 ` Jason Wang
2021-04-13 4:52 ` Michael S. Tsirkin
2021-04-13 4:42 ` Michael S. Tsirkin
2021-04-13 10:56 ` Max Gurtovoy
2021-04-08 16:18 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210408081109.56537-2-mgurtovoy@nvidia.com \
--to=mgurtovoy@nvidia.com \
--cc=cohuck@redhat.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=nitzanc@nvidia.com \
--cc=oren@nvidia.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox