Re: [PATCH v13 03/13] vfio: VFIO_IOMMU_SET_MSI_BINDING

kernel test robot
2021-04-11T15:29:11Z

[-- Attachment #1: Type: text/plain, Size: 3936 bytes --]

Hi Eric,

I love your patch! Yet something to improve:

[auto build test ERROR on v5.12-rc6]
[also build test ERROR on next-20210409]
[cannot apply to vfio/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Eric-Auger/SMMUv3-Nested-Stage-Setup-VFIO-part/20210411-195216
base: e49d033bddf5b565044e2abe4241353959bc9120
config: i386-randconfig-s001-20210411 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-279-g6d5d9b42-dirty
# https://github.com/0day-ci/linux/commit/8a9991f0409cae6af9a387b8b90dbb7ad004f590
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Eric-Auger/SMMUv3-Nested-Stage-Setup-VFIO-part/20210411-195216
git checkout 8a9991f0409cae6af9a387b8b90dbb7ad004f590
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

In file included from include/linux/vfio.h:16,
from drivers/vfio/vfio_iommu_type1.c:37:
include/uapi/linux/vfio.h:1226:34: error: field 'config' has incomplete type
1226 | struct iommu_pasid_table_config config; /* used on SET */
| ^~~~~~
drivers/vfio/vfio_iommu_type1.c: In function 'vfio_detach_pasid_table':
drivers/vfio/vfio_iommu_type1.c:2872:3: error: implicit declaration of function 'iommu_detach_pasid_table'; did you mean 'vfio_detach_pasid_table'? [-Werror=implicit-function-declaration]
2872 | iommu_detach_pasid_table(d->domain);
| ^~~~~~~~~~~~~~~~~~~~~~~~
| vfio_detach_pasid_table
drivers/vfio/vfio_iommu_type1.c: In function 'vfio_attach_pasid_table':
drivers/vfio/vfio_iommu_type1.c:2886:9: error: implicit declaration of function 'iommu_uapi_attach_pasid_table'; did you mean 'vfio_attach_pasid_table'? [-Werror=implicit-function-declaration]
2886 | ret = iommu_uapi_attach_pasid_table(d->domain, (void __user *)arg);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| vfio_attach_pasid_table
drivers/vfio/vfio_iommu_type1.c: In function 'vfio_bind_msi':
>> drivers/vfio/vfio_iommu_type1.c:2915:9: error: implicit declaration of function 'iommu_bind_guest_msi' [-Werror=implicit-function-declaration]
2915 | ret = iommu_bind_guest_msi(d->domain, giova, gpa, size);
| ^~~~~~~~~~~~~~~~~~~~
>> drivers/vfio/vfio_iommu_type1.c:2922:3: error: implicit declaration of function 'iommu_unbind_guest_msi' [-Werror=implicit-function-declaration]
2922 | iommu_unbind_guest_msi(d->domain, giova);
| ^~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors

vim +/iommu_bind_guest_msi +2915 drivers/vfio/vfio_iommu_type1.c

2904
2905 static int
2906 vfio_bind_msi(struct vfio_iommu *iommu,
2907 dma_addr_t giova, phys_addr_t gpa, size_t size)
2908 {
2909 struct vfio_domain *d;
2910 int ret = 0;
2911
2912 mutex_lock(&iommu->lock);
2913
2914 list_for_each_entry(d, &iommu->domain_list, next) {
> 2915 ret = iommu_bind_guest_msi(d->domain, giova, gpa, size);
2916 if (ret)
2917 goto unwind;
2918 }
2919 goto unlock;
2920 unwind:
2921 list_for_each_entry_continue_reverse(d, &iommu->domain_list, next) {
> 2922 iommu_unbind_guest_msi(d->domain, giova);
2923 }
2924 unlock:
2925 mutex_unlock(&iommu->lock);
2926 return ret;
2927 }
2928

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27096 bytes --]