From: Cornelia Huck <cohuck@redhat.com>
To: Janosch Frank <frankja@linux.ibm.com>
Cc: kvm@vger.kernel.org, david@redhat.com,
linux-s390@vger.kernel.org, imbrenda@linux.ibm.com,
thuth@redhat.com
Subject: Re: [kvm-unit-tests PATCH v2 2/3] lib: s390x: sclp: Extend feature probing
Date: Wed, 19 May 2021 12:17:11 +0200 [thread overview]
Message-ID: <20210519121711.22ed02ba.cohuck@redhat.com> (raw)
In-Reply-To: <20210519082648.46803-3-frankja@linux.ibm.com>
On Wed, 19 May 2021 08:26:47 +0000
Janosch Frank <frankja@linux.ibm.com> wrote:
> Lets grab more of the feature bits from SCLP read info so we can use
s/Lets/Let's/ :)
> them in the cpumodel tests.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> ---
> lib/s390x/sclp.c | 20 ++++++++++++++++++++
> lib/s390x/sclp.h | 38 +++++++++++++++++++++++++++++++++++---
> 2 files changed, 55 insertions(+), 3 deletions(-)
(...)
Maybe add
/* bit number within a certain byte */
> +#define SCLP_FEAT_85_BIT_GSLS 7
> +#define SCLP_FEAT_98_BIT_KSS 0
> +#define SCLP_FEAT_116_BIT_64BSCAO 7
> +#define SCLP_FEAT_116_BIT_CMMA 6
> +#define SCLP_FEAT_116_BIT_ESCA 3
> +#define SCLP_FEAT_117_BIT_PFMFI 6
> +#define SCLP_FEAT_117_BIT_IBS 5
> +
> typedef struct ReadInfo {
> SCCBHeader h;
> uint16_t rnmax;
Acked-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2021-05-19 10:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 8:26 [kvm-unit-tests PATCH v2 0/3] s390x: cpumodel: Add sclp checks Janosch Frank
2021-05-19 8:26 ` [kvm-unit-tests PATCH v2 1/3] s390x: sclp: Only fetch read info byte 134 if cpu entries are above it Janosch Frank
2021-05-19 8:26 ` [kvm-unit-tests PATCH v2 2/3] lib: s390x: sclp: Extend feature probing Janosch Frank
2021-05-19 9:06 ` David Hildenbrand
2021-05-19 10:17 ` Cornelia Huck [this message]
2021-05-19 10:43 ` Janosch Frank
2021-05-19 8:26 ` [kvm-unit-tests PATCH v2 3/3] s390x: cpumodel: FMT2 and FMT4 SCLP test Janosch Frank
2021-05-19 10:19 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210519121711.22ed02ba.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox