From: Steven Rostedt <rostedt@goodmis.org>
To: Sean Christopherson <seanjc@google.com>
Cc: Wanpeng Li <kernellwp@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm <kvm@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KVM: x86: Ensure liveliness of nested VM-Enter fail tracepoint message
Date: Wed, 9 Jun 2021 13:01:53 -0400 [thread overview]
Message-ID: <20210609130153.42b3ca81@oasis.local.home> (raw)
In-Reply-To: <YMDoeDTrAMmfl6+k@google.com>
On Wed, 9 Jun 2021 09:12:40 -0700
Sean Christopherson <seanjc@google.com> wrote:
> > I can observe tons of other kvm tracepoints warning like this after
> > commit 9a6944fee68e25 (tracing: Add a verifier to check string
> > pointers for trace events), just echo 1 >
> > /sys/kernel/tracing/events/kvm/enable and boot a linux guest.
>
> Can you provide your .config? With all of events/kvm and events/kvmmmu enabled
> I don't get any warnings running a Linux guest, a nested Linux guest, and
> kvm-unit-tests.
>
> Do you see the behavior with other tracepoints? E.g. enabling all events on my
> systems yields warnings for a USB module, but everything else is clean.
Right, I tested this with running KVM guests when it was added. I was
actually surprised with Sean's report saying it was a kvm trace event,
until I noticed that the problem event is only triggered on error paths.
-- Steve
next prev parent reply other threads:[~2021-06-09 17:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 17:57 [PATCH] KVM: x86: Ensure liveliness of nested VM-Enter fail tracepoint message Sean Christopherson
2021-06-07 18:48 ` Steven Rostedt
2021-06-08 17:30 ` Paolo Bonzini
2021-06-09 6:10 ` Wanpeng Li
2021-06-09 16:12 ` Sean Christopherson
2021-06-09 17:01 ` Steven Rostedt [this message]
2021-06-10 12:12 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210609130153.42b3ca81@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox