From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12C47C47094 for ; Thu, 10 Jun 2021 16:13:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE77D613B3 for ; Thu, 10 Jun 2021 16:13:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230083AbhFJQPu (ORCPT ); Thu, 10 Jun 2021 12:15:50 -0400 Received: from foss.arm.com ([217.140.110.172]:35838 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229802AbhFJQPt (ORCPT ); Thu, 10 Jun 2021 12:15:49 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 33CFBED1; Thu, 10 Jun 2021 09:13:53 -0700 (PDT) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 13BE33F719; Thu, 10 Jun 2021 09:13:51 -0700 (PDT) Date: Thu, 10 Jun 2021 17:13:45 +0100 From: Andre Przywara To: Alexandru Elisei Cc: will@kernel.org, julien.thierry.kdev@gmail.com, kvm@vger.kernel.org, sami.mujawar@arm.com, lorenzo.pieralisi@arm.com, maz@kernel.org Subject: Re: [PATCH kvmtool 2/4] arm/fdt.c: Warn if MMIO device doesn't provide a node generator Message-ID: <20210610171345.79919d7b@slackpad.fritz.box> In-Reply-To: <20210609183812.29596-3-alexandru.elisei@arm.com> References: <20210609183812.29596-1-alexandru.elisei@arm.com> <20210609183812.29596-3-alexandru.elisei@arm.com> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, 9 Jun 2021 19:38:10 +0100 Alexandru Elisei wrote: > Print a more helpful warning when a MMIO device hasn't set a function to > generate an FDT instead of causing a segmentation fault by dereferencing a > NULL pointer. Not calling generate_mmio_fdt_nodes() if it's NULL is certainly a good idea, but how did you trigger it? Because I am wondering whether every MMIO device needs to have an DT generator? And if that's not the case, a warning might be already too much. So either just drop a print at all or use pr_info()/pr_debug()? Cheers, Andre > > Signed-off-by: Alexandru Elisei > --- > arm/fdt.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/arm/fdt.c b/arm/fdt.c > index 02091e9e0bee..06287a13e395 100644 > --- a/arm/fdt.c > +++ b/arm/fdt.c > @@ -171,7 +171,12 @@ static int setup_fdt(struct kvm *kvm) > dev_hdr = device__first_dev(DEVICE_BUS_MMIO); > while (dev_hdr) { > generate_mmio_fdt_nodes = dev_hdr->data; > - generate_mmio_fdt_nodes(fdt, dev_hdr, generate_irq_prop); > + if (generate_mmio_fdt_nodes) { > + generate_mmio_fdt_nodes(fdt, dev_hdr, generate_irq_prop); > + } else { > + pr_warning("Missing FDT node generator for MMIO device %d", > + dev_hdr->dev_num); > + } > dev_hdr = device__next_dev(dev_hdr); > } >