[kvm-unit-tests PATCH] Avoid backticks, use $() instead

[kvm-unit-tests PATCH] Avoid backticks, use $() instead

[Thomas Huth]

The backticks are considered as bad style these days, e.g. when checking
scripts with https://www.shellcheck.net/ ... let's use the modern $()
syntax instead.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 configure             |  2 +-
 run_tests.sh          |  2 +-
 scripts/arch-run.bash | 10 +++++-----
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/configure b/configure
index 71aaad4..d21601f 100755
--- a/configure
+++ b/configure
@@ -13,7 +13,7 @@ objcopy=objcopy
 objdump=objdump
 ar=ar
 addr2line=addr2line
-arch=`uname -m | sed -e 's/i.86/i386/;s/arm.*/arm/;s/ppc64.*/ppc64/'`
+arch=$(uname -m | sed -e 's/i.86/i386/;s/arm.*/arm/;s/ppc64.*/ppc64/')
 host=$arch
 cross_prefix=
 endian=""
diff --git a/run_tests.sh b/run_tests.sh
index 65108e7..9f233c5 100755
--- a/run_tests.sh
+++ b/run_tests.sh
@@ -42,7 +42,7 @@ if [ $? -ne 4 ]; then
 fi
 
 only_tests=""
-args=`getopt -u -o ag:htj:v -l all,group:,help,tap13,parallel:,verbose -- $*`
+args=$(getopt -u -o ag:htj:v -l all,group:,help,tap13,parallel:,verbose -- $*)
 [ $? -ne 0 ] && exit 2;
 set -- $args;
 while [ $# -gt 0 ]; do
diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash
index 5997e38..9dd963b 100644
--- a/scripts/arch-run.bash
+++ b/scripts/arch-run.bash
@@ -111,11 +111,11 @@ run_migration ()
 		return 2
 	fi
 
-	migsock=`mktemp -u -t mig-helper-socket.XXXXXXXXXX`
-	migout1=`mktemp -t mig-helper-stdout1.XXXXXXXXXX`
-	qmp1=`mktemp -u -t mig-helper-qmp1.XXXXXXXXXX`
-	qmp2=`mktemp -u -t mig-helper-qmp2.XXXXXXXXXX`
-	fifo=`mktemp -u -t mig-helper-fifo.XXXXXXXXXX`
+	migsock=$(mktemp -u -t mig-helper-socket.XXXXXXXXXX)
+	migout1=$(mktemp -t mig-helper-stdout1.XXXXXXXXXX)
+	qmp1=$(mktemp -u -t mig-helper-qmp1.XXXXXXXXXX)
+	qmp2=$(mktemp -u -t mig-helper-qmp2.XXXXXXXXXX)
+	fifo=$(mktemp -u -t mig-helper-fifo.XXXXXXXXXX)
 	qmpout1=/dev/null
 	qmpout2=/dev/null
 
-- 
2.27.0

Re: [kvm-unit-tests PATCH] Avoid backticks, use $() instead

[Andrew Jones]

On Tue, Jun 22, 2021 at 11:12:37AM +0200, Thomas Huth wrote:
> The backticks are considered as bad style these days, e.g. when checking
> scripts with https://www.shellcheck.net/ ... let's use the modern $()
> syntax instead.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  configure             |  2 +-
>  run_tests.sh          |  2 +-
>  scripts/arch-run.bash | 10 +++++-----
>  3 files changed, 7 insertions(+), 7 deletions(-)

Applied to misc/queue

https://gitlab.com/rhdrjones/kvm-unit-tests/-/commits/misc/queue

Thanks,
drew