From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Janosch Frank <frankja@linux.ibm.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
david@redhat.com, cohuck@redhat.com
Subject: Re: [kvm-unit-tests PATCH 3/5] lib: s390x: uv: Int type cleanup
Date: Fri, 23 Jul 2021 19:15:52 +0200 [thread overview]
Message-ID: <20210723191552.66fd67c9@p-imbrenda> (raw)
In-Reply-To: <b06633be-3832-7a07-37c3-1beaecd2202a@redhat.com>
On Mon, 5 Jul 2021 11:41:57 +0200
Thomas Huth <thuth@redhat.com> wrote:
[snip]
>
> Completely inaccurate checks with the lib directory of the
> kvm-unit-tests:
>
> $ grep -r u64 lib/ | wc -l
> 234
> $ grep -r uint64 lib/ | wc -l
> 245
>
> $ grep -r u8 lib/ | wc -l
> 137
> $ grep -r uint8 lib/ | wc -l
> 193
>
> ... I guess that's an indication that we do not really have a
> prevailing style here?
> I personally prefer the stdint.h types, I'm just not sure whether it
> makes sense to keep some headers close to the kernel or not...?
>
> Thomas
>
I agree, the project as a whole needs to decide the policy regarding
stdint.h types. Do we want them always? only for stuff that doesn't
need synchronization with the kernel? or maybe we just don't care?
I don't care which way we go, but I think we need to decide on one way
to go.
next prev parent reply other threads:[~2021-07-23 17:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 13:33 [kvm-unit-tests PATCH 0/5] s390x: sie and uv cleanups Janosch Frank
2021-06-29 13:33 ` [kvm-unit-tests PATCH 1/5] s390x: sie: Add missing includes Janosch Frank
2021-06-30 8:59 ` Cornelia Huck
2021-07-04 7:47 ` Thomas Huth
2021-07-23 17:10 ` Claudio Imbrenda
2021-06-29 13:33 ` [kvm-unit-tests PATCH 2/5] s390x: sie: Fix sie.h integer types Janosch Frank
2021-06-30 9:00 ` Cornelia Huck
2021-07-04 7:45 ` Thomas Huth
2021-07-23 17:10 ` Claudio Imbrenda
2021-06-29 13:33 ` [kvm-unit-tests PATCH 3/5] lib: s390x: uv: Int type cleanup Janosch Frank
2021-06-30 9:03 ` Cornelia Huck
2021-07-04 7:51 ` Thomas Huth
2021-07-05 9:33 ` Janosch Frank
2021-07-05 9:41 ` Thomas Huth
2021-07-23 17:15 ` Claudio Imbrenda [this message]
2021-06-29 13:33 ` [kvm-unit-tests PATCH 4/5] lib: s390x: uv: Add offset comments to uv_query and extend it Janosch Frank
2021-06-30 9:06 ` Cornelia Huck
2021-06-30 9:43 ` Janosch Frank
2021-07-23 17:22 ` Claudio Imbrenda
2021-06-29 13:33 ` [kvm-unit-tests PATCH 5/5] lib: s390x: Print if a pgm happened while in SIE Janosch Frank
2021-06-30 9:12 ` Cornelia Huck
2021-07-23 17:25 ` Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210723191552.66fd67c9@p-imbrenda \
--to=imbrenda@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox