Re: [kvm-unit-tests PATCH 1/3] s390x: Add SPDX and header comments for s390x/* and lib/s390x/*

[Claudio Imbrenda <imbrenda@linux.ibm.com>]

On Wed, 28 Jul 2021 10:13:26 +0000
Janosch Frank <frankja@linux.ibm.com> wrote:

> Seems like I missed adding them.
> 
> The s390x/sieve.c one is a bit of a head scratcher since it came with
> the first commit but I assume it's lpgl2-only since that's what the
> COPYRIGHT file said then.
> 
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
>  lib/s390x/uv.c   |  9 +++++++++
>  s390x/mvpg-sie.c |  9 +++++++++
>  s390x/sie.c      | 10 ++++++++++
>  x86/sieve.c      |  5 +++++
>  4 files changed, 33 insertions(+)
> 
> diff --git a/lib/s390x/uv.c b/lib/s390x/uv.c
> index 0d8c141c..fd9de944 100644
> --- a/lib/s390x/uv.c
> +++ b/lib/s390x/uv.c
> @@ -1,3 +1,12 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Ultravisor related functionality
> + *
> + * Copyright 2020 IBM Corp.
> + *
> + * Authors:
> + *    Janosch Frank <frankja@linux.ibm.com>
> + */
>  #include <libcflat.h>
>  #include <bitops.h>
>  #include <alloc.h>
> diff --git a/s390x/mvpg-sie.c b/s390x/mvpg-sie.c
> index 9bcd15a2..5e70f591 100644
> --- a/s390x/mvpg-sie.c
> +++ b/s390x/mvpg-sie.c
> @@ -1,3 +1,12 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Tests mvpg SIE partial execution intercepts.
> + *
> + * Copyright 2021 IBM Corp.
> + *
> + * Authors:
> + *    Janosch Frank <frankja@linux.ibm.com>
> + */
>  #include <libcflat.h>
>  #include <asm/asm-offsets.h>
>  #include <asm-generic/barrier.h>
> diff --git a/s390x/sie.c b/s390x/sie.c
> index cfc746f3..134d3c4f 100644
> --- a/s390x/sie.c
> +++ b/s390x/sie.c
> @@ -1,3 +1,13 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Tests SIE diagnose intercepts.
> + * Mainly used as a template for SIE tests.
> + *
> + * Copyright 2021 IBM Corp.
> + *
> + * Authors:
> + *    Janosch Frank <frankja@linux.ibm.com>
> + */
>  #include <libcflat.h>
>  #include <asm/asm-offsets.h>
>  #include <asm/arch_def.h>
> diff --git a/x86/sieve.c b/x86/sieve.c
> index 8150f2d9..b89d5f80 100644
> --- a/x86/sieve.c
> +++ b/x86/sieve.c
> @@ -1,3 +1,8 @@
> +/* SPDX-License-Identifier: LGPL-2.0-only */

do you really need to fix something in the x86 directory? (even though
it is also used on other archs)

maybe you can split out this as a separate patch, so s390x stuff is
more self contained, and others can then discuss the sieve.c patch
separately if needed?

> +/*
> + * Implementation of the sieve of Eratosthenes
> + * Calculation and memory intensive workload for general stress
> testing.
> + */
>  #include "alloc.h"
>  #include "libcflat.h"
>