Re: [kvm-unit-tests PATCH v2] s390x: sie: Add sie lib validity handling

Thomas Huth
2021-08-03T14:47:56Z

On 03/08/2021 15.57, Janosch Frank wrote:
> Let's start off the SIE lib with validity handling code since that has
> the least amount of dependencies to other files.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> ---
> lib/s390x/sie.c | 40 ++++++++++++++++++++++++++++++++++++++++
> lib/s390x/sie.h | 3 +++
> s390x/Makefile | 1 +
> s390x/mvpg-sie.c | 2 +-
> s390x/sie.c | 7 +------
> 5 files changed, 46 insertions(+), 7 deletions(-)
> create mode 100644 lib/s390x/sie.c
>
> diff --git a/lib/s390x/sie.c b/lib/s390x/sie.c
> new file mode 100644
> index 00000000..15ba407c
> --- /dev/null
> +++ b/lib/s390x/sie.c
> @@ -0,0 +1,40 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Virtualization library that speeds up managing guests.

Maybe something like:

Library for managing various aspects of (nested) guests

?

Anyway:
Reviewed-by: Thomas Huth <thuth@redhat.com>