Re: [kvm-unit-tests PATCH 1/4] s390x: sie: Add sie lib validity handling

Thomas Huth
2021-07-30T14:45:56Z

On 29/07/2021 15.48, Janosch Frank wrote:
> Let's start off the SIE lib with validity handling code since that has
> the least amount of dependencies to other files.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
> lib/s390x/sie.c | 41 +++++++++++++++++++++++++++++++++++++++++
> lib/s390x/sie.h | 3 +++
> s390x/Makefile | 1 +
> s390x/mvpg-sie.c | 2 +-
> s390x/sie.c | 7 +------
> 5 files changed, 47 insertions(+), 7 deletions(-)
> create mode 100644 lib/s390x/sie.c
>
> diff --git a/lib/s390x/sie.c b/lib/s390x/sie.c
> new file mode 100644
> index 00000000..9107519f
> --- /dev/null
> +++ b/lib/s390x/sie.c
> @@ -0,0 +1,41 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Virtualization library that speeds up managing guests.

"speeds up managing guests" ... so this means that guests can be scheduled
faster? ;-)

> + * Copyright (c) 2021 IBM Corp
> + *
> + * Authors:
> + * Janosch Frank <frankja@linux.ibm.com>
> + */
> +
> +#include <asm/barrier.h>
> +#include <libcflat.h>
> +#include <sie.h>
> +
> +static bool validity_expected;
> +static uint16_t vir;

What does "vir" stand for? A short comment would be nice.

Thomas