From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C41E3C4320A for ; Mon, 2 Aug 2021 20:12:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A2F92610FB for ; Mon, 2 Aug 2021 20:12:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231408AbhHBUMP (ORCPT ); Mon, 2 Aug 2021 16:12:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:60828 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230420AbhHBUMP (ORCPT ); Mon, 2 Aug 2021 16:12:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627935125; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q52w6Q4YtuhtQOV0oJmgEUraWN88/oaIpPIXQ4cq1HY=; b=LE0/8pkSOZcet6YCYBENzHDVMIQNfhM6lL7mYED5VZpbWc/H8slVirXD3rhjcKyI92EgD6 yN/RyDTZS5WQdGMT6ZG6V3DpEte1/YuyCgdLXHeNgJzuS0Fi4feQ5VqvbCKsr/oaqZBzgZ sCwnvaNRb5VuCIlJWDoGqikhrSuGTOc= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-504-3BmtIjX7OGytG-B05u2MfA-1; Mon, 02 Aug 2021 16:12:03 -0400 X-MC-Unique: 3BmtIjX7OGytG-B05u2MfA-1 Received: by mail-ed1-f70.google.com with SMTP id x1-20020a05640218c1b02903bc7f97f858so7746282edy.2 for ; Mon, 02 Aug 2021 13:12:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=q52w6Q4YtuhtQOV0oJmgEUraWN88/oaIpPIXQ4cq1HY=; b=A2DkfNq5JeLj5dJYHHtdLe/NRrgH6QK786ysX5lu4vUlmZO9yVJC5mK+GVIM2rqqTe lZqNzCv3RD62bkkzExtcFAUyOs/vDNXYVgvNg6iYa2PonVcz5QUluikvcOnvSVexDn3N kfA0WCTg/1qa1T41qSpKNQ9VxErKk8iIpn4RMoDAw19aJUL9QPAQgqvWiSWBSVPJckrP sg3wL4z1UASwrdVp0oLjKufxkQUf+Yaht56rzwFY9U2rhENJwa1GMpB2camCiOaUeu4Q YtCTDW7oa24BJ03B6fP7c1S3AdIfegKxwQuTuPt+6p5NxzPUYIoKBGOn6A0J2GS95zmj BD2Q== X-Gm-Message-State: AOAM533DXfIAEWNDPKRdSzqJmSeFgEGXrIt1u5OYZ76rPJrRn5LTiCFd yiE529lE0CrGAbFzSGtUIFMigIm3eKKTjemzWeqBuzwTQWuXVhj4y4Gggy/rpypMrL88+IkqtFD Zfs/cfJvk3KNN X-Received: by 2002:aa7:c0d1:: with SMTP id j17mr21235854edp.217.1627935122739; Mon, 02 Aug 2021 13:12:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyfr39sns4u7IHD+697IXe7EyNtPI7YycI0ox/3uN10j7vd/YANYQrljcKZhj+LRbcxif46Ug== X-Received: by 2002:aa7:c0d1:: with SMTP id j17mr21235843edp.217.1627935122638; Mon, 02 Aug 2021 13:12:02 -0700 (PDT) Received: from redhat.com ([2.55.140.205]) by smtp.gmail.com with ESMTPSA id o7sm4957679ejy.48.2021.08.02.13.11.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Aug 2021 13:12:02 -0700 (PDT) Date: Mon, 2 Aug 2021 16:11:57 -0400 From: "Michael S. Tsirkin" To: fuguancheng Cc: jasowang@redhat.com, stefanha@redhat.com, sgarzare@redhat.com, davem@davemloft.net, kuba@kernel.org, arseny.krasnov@kaspersky.com, andraprs@amazon.com, colin.king@canonical.com, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] VSOCK DRIVER: Add multi-cid support for guest Message-ID: <20210802161055-mutt-send-email-mst@kernel.org> References: <20210802120720.547894-1-fuguancheng@bytedance.com> <20210802120720.547894-2-fuguancheng@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210802120720.547894-2-fuguancheng@bytedance.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Aug 02, 2021 at 08:07:17PM +0800, fuguancheng wrote: > diff --git a/include/uapi/linux/virtio_vsock.h b/include/uapi/linux/virtio_vsock.h > index 3dd3555b2740..0afc14446b01 100644 > --- a/include/uapi/linux/virtio_vsock.h > +++ b/include/uapi/linux/virtio_vsock.h > @@ -42,7 +42,8 @@ > #define VIRTIO_VSOCK_F_SEQPACKET 1 /* SOCK_SEQPACKET supported */ > > struct virtio_vsock_config { > - __le64 guest_cid; > + __le32 number_cid; > + __le64 cids[]; > } __attribute__((packed)); any host/guest interface change needs to copy the virtio TC. packing here is a bad idea imho, just add explicit padding. -- MST