From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B5A6C4338F for ; Tue, 10 Aug 2021 21:16:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D767460E9B for ; Tue, 10 Aug 2021 21:16:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234213AbhHJVQl (ORCPT ); Tue, 10 Aug 2021 17:16:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:57791 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234176AbhHJVQk (ORCPT ); Tue, 10 Aug 2021 17:16:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628630177; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k7GQyRF3T2F5cFOMo5DgAfgkHKpFg4ySwpREk5VvgQw=; b=dBdq4p0GzBJ9GNb+50XKHI7vLqSWPyUyruNTYRn0uLRIASTRDQLL82e3Ixwr649rxDa/kx kTYbLc7fGYlsCk9iLGtogsHiU0CaKNu16jCbATHws55VPCjQBsEzWSUQhgMV+O8gaIKIDS UTk9HpB3jNSbn6i7tgX/4eQjw2yKPMI= Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-255-FsLqpQEOMO-qkA60ovGY_A-1; Tue, 10 Aug 2021 17:16:16 -0400 X-MC-Unique: FsLqpQEOMO-qkA60ovGY_A-1 Received: by mail-oi1-f199.google.com with SMTP id be10-20020a056808218ab02902671f63963eso300922oib.18 for ; Tue, 10 Aug 2021 14:16:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=k7GQyRF3T2F5cFOMo5DgAfgkHKpFg4ySwpREk5VvgQw=; b=FWpfSY2pBq2fdIngI1qE/otQ4skBSqZY5N33hLXl2Qk+i4WePWgz8xfdWh2U/6cNuR VNKmmZykGPQGOT4C3Ukp18fp3+IcuKQb7Wyf/In+t7rA/NMblMzmUy2Ske/3h2/RP4JX NyKinyMPiuzDwFr7CJcpFkEx0K6KFdab91apQEfMesg0YgaXpBtomoA8Ex+rHqiflilr ddBvbWKyN1jKGZAgCg3cBsgafgWy2a97HQbBgilyVz+E2zSkH9W9tIEZeWXQwnLiM/HH p5y6rGoIl7SAeIRcGQ0HKVXdA8/VYPm1byYi7BaBqrMJ+ZbgtmGwM5n/XE38clCQW8Qf 7BDg== X-Gm-Message-State: AOAM5306JFlAStNNq+vSpGguAv3E+OLb1bwMUljlKYdA0s5lPuzAaeSc hnO1ueNBr1mAKHHcnMEmxZWvTU+Fh0wur4g3Xh0dE3q4gQUdpTmCLunzAj1/zrrfVlSIdMnA7ks q6ogv8PZvWRem X-Received: by 2002:a05:6830:2a09:: with SMTP id y9mr22889066otu.217.1628630175791; Tue, 10 Aug 2021 14:16:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJtU1OkXmxYAP/vQsRrWUR2KaD6Zcstm/KC8LV/WJpIlYUp20POKRjVottBiXJCgi4DHznug== X-Received: by 2002:a05:6830:2a09:: with SMTP id y9mr22889054otu.217.1628630175618; Tue, 10 Aug 2021 14:16:15 -0700 (PDT) Received: from redhat.com ([198.99.80.109]) by smtp.gmail.com with ESMTPSA id w35sm4062698ott.80.2021.08.10.14.16.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 14:16:15 -0700 (PDT) Date: Tue, 10 Aug 2021 15:16:14 -0600 From: Alex Williamson To: Peter Xu Cc: Christoph Hellwig , Jason Gunthorpe , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH 1/7] vfio: Create vfio_fs_type with inode per device Message-ID: <20210810151614.39a6714f.alex.williamson@redhat.com> In-Reply-To: References: <162818167535.1511194.6614962507750594786.stgit@omen> <162818322947.1511194.6035266132085405252.stgit@omen> <20210810085254.51da01d6.alex.williamson@redhat.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, 10 Aug 2021 14:49:45 -0400 Peter Xu wrote: > On Tue, Aug 10, 2021 at 03:57:29PM +0100, Christoph Hellwig wrote: > > On Tue, Aug 10, 2021 at 08:52:54AM -0600, Alex Williamson wrote: > > > On Tue, 10 Aug 2021 10:43:29 +0200 > > > Christoph Hellwig wrote: > > > > > > > > + * XXX Adopt the following when available: > > > > > + * https://lore.kernel.org/lkml/20210309155348.974875-1-hch@lst.de/ > > > > > > > > No need for this link. > > > > > > Is that effort dead? I've used the link several times myself to search > > > for progress, so it's been useful to me. Thanks, > > > > No, but it seems odd to have reference to an old patchset in the kernel > > tree. > > I learn from the reference too. Maybe move into commit message? Thanks, TBH, I'm ok if it's "odd" if it's useful. Right here we have two instances of it being useful. I don't think that two lines of comment is excessive and we can always remove it when we either make the conversion or give up on it. Moving it to the commit log would just bury it to be pointless. I don't have a more concise, current, or future-proof way to describe the todo item than this link (ok, ok, I could s/lkml/r/ for 3 less chars :-P). Thanks, Alex