From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D077C4338F for ; Tue, 10 Aug 2021 21:45:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B2EC60EE9 for ; Tue, 10 Aug 2021 21:45:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234715AbhHJVpk (ORCPT ); Tue, 10 Aug 2021 17:45:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:30861 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234434AbhHJVpj (ORCPT ); Tue, 10 Aug 2021 17:45:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628631916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lx2uWYFZRkWia4mHYWRkdZx8DwSlvSdbBOWfMTQd9Bk=; b=jQ36H/0RtXvnY/tkGhY2alSZW0kmGRygk3OG5Bqe8B0suyW8i78D0O+TMTnqxz2LuHxiBd UAq/TJh2stu9bAZU98jiBji5MmHGC2MJtiPED2n3FiUffEKl1rtpz7tnNeIWU0TfHkw0y8 PsxpIwS2lRhDovjVr668Pw++Pdsft/Q= Received: from mail-oo1-f70.google.com (mail-oo1-f70.google.com [209.85.161.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-337-P0ndGvCaOM69za_-sud4LQ-1; Tue, 10 Aug 2021 17:45:14 -0400 X-MC-Unique: P0ndGvCaOM69za_-sud4LQ-1 Received: by mail-oo1-f70.google.com with SMTP id u5-20020a4a97050000b029026a71f65966so107137ooi.2 for ; Tue, 10 Aug 2021 14:45:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lx2uWYFZRkWia4mHYWRkdZx8DwSlvSdbBOWfMTQd9Bk=; b=O3J7Io6tYssRq25dqR3bEym3ZdQsLLUHSN1KEuwF6RDjVCm+vZblmNE/J7z4b69yCZ TZNekcqqC23w6RvhtGyRa4g6dbN26ySoix3heCkjw6BAVuOj89jmRvVYDYkUSZUS8Qz1 9lNf9hqI8UWhXrD+iZW4Tf1ZEkovaNgZE37cUvNiHfjmvvscpMYuHbQdNvosBpLZiAlU Fo3egAtqxMVhOqiHpZbsbpE9qRgZL1IP6puUZxCpO75BJqwRPIDKvimagg+LuShRJ4eK qlYEuZoD/ADg/w02R6eAMknmhP/nW0hVnYBtHWtasNbgL6/KeJsxEXnKzRyWWiChNjCQ y9uw== X-Gm-Message-State: AOAM533PZIvXfKYQ2pmm3I+QGhgltYXiitJ6ULvekxfEOaeIsXQ9Yl2z f1pYK0ZTDmomx3JS9ALuvOAy8/bm9uDCzV92S6TgqprOjPkg4bjkrRIh2g9N7K+X65fbJidDglS MvQb95T1yffEk X-Received: by 2002:a9d:84c:: with SMTP id 70mr12855826oty.344.1628631914187; Tue, 10 Aug 2021 14:45:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6Ary8a1ESo9zoHrr/4X7svWaGu5Lqsi/I+gg1HHwrs8HuQtFwcEHHfgHpn5voCQdKzkbzAQ== X-Received: by 2002:a9d:84c:: with SMTP id 70mr12855815oty.344.1628631913982; Tue, 10 Aug 2021 14:45:13 -0700 (PDT) Received: from redhat.com ([198.99.80.109]) by smtp.gmail.com with ESMTPSA id r137sm3455476oie.17.2021.08.10.14.45.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 14:45:13 -0700 (PDT) Date: Tue, 10 Aug 2021 15:45:12 -0600 From: Alex Williamson To: Peter Xu Cc: Jason Gunthorpe , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH 7/7] vfio/pci: Remove map-on-fault behavior Message-ID: <20210810154512.5aa8eeb3.alex.williamson@redhat.com> In-Reply-To: References: <162818167535.1511194.6614962507750594786.stgit@omen> <162818330190.1511194.10498114924408843888.stgit@omen> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, 10 Aug 2021 16:54:19 -0400 Peter Xu wrote: > On Thu, Aug 05, 2021 at 11:08:21AM -0600, Alex Williamson wrote: > > diff --git a/drivers/vfio/pci/vfio_pci_private.h b/drivers/vfio/pci/vfio_pci_private.h > > index 0aa542fa1e26..9aedb78a4ae3 100644 > > --- a/drivers/vfio/pci/vfio_pci_private.h > > +++ b/drivers/vfio/pci/vfio_pci_private.h > > @@ -128,6 +128,7 @@ struct vfio_pci_device { > > bool needs_reset; > > bool nointx; > > bool needs_pm_restore; > > + bool zapped_bars; > > Would it be nicer to invert the meaning of "zapped_bars" and rename it to > "memory_enabled"? Thanks, I think this has it's own down sides, for example is this really less confusing?: if (!vdev->memory_enabled && __vfio_pci_memory_enabled(vdev)) Are you specifically trying to invert the polarity or just get away from the name proposed here? We could use something like "bars_unmapped", which would have the same polarity (OTOH, "bars_mapped" suggests something to me about whether the user has performed any mmaps of BARs). I do wish there was a more elegant solution than an @var tracking this state in general, but I haven't come up with such a solution yet. Thanks, Alex