Re: [kvm-unit-tests PATCH 6/8] lib: s390x: Add PSW_MASK_64

Thomas Huth
2021-08-18T09:28:57Z

On 13/08/2021 09.36, Janosch Frank wrote:
> Let's replace the magic 0x0000000180000000ULL numeric constants with
> PSW_MASK_64 as it's used more often since the introduction of smp and
> sie.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
> lib/s390x/asm/arch_def.h | 3 +++
> lib/s390x/smp.c | 2 +-
> s390x/mvpg-sie.c | 2 +-
> s390x/sie.c | 2 +-
> s390x/skrf.c | 6 +++---
> 5 files changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/lib/s390x/asm/arch_def.h b/lib/s390x/asm/arch_def.h
> index 39c5ba99..245453c3 100644
> --- a/lib/s390x/asm/arch_def.h
> +++ b/lib/s390x/asm/arch_def.h
> @@ -50,6 +50,9 @@ struct psw {
> #define PSW_MASK_DAT 0x0400000000000000UL
> #define PSW_MASK_WAIT 0x0002000000000000UL
> #define PSW_MASK_PSTATE 0x0001000000000000UL
> +#define PSW_MASK_EA 0x0000000100000000UL
> +#define PSW_MASK_BA 0x0000000080000000UL
> +#define PSW_MASK_64 PSW_MASK_BA | PSW_MASK_EA;

Please put some parentheses around PSW_MASK_BA | PSW_MASK_EA and remove the
semicolon at the end.

Thomas