From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF58EC43214 for ; Fri, 13 Aug 2021 08:50:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3ADC6103E for ; Fri, 13 Aug 2021 08:50:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239445AbhHMIvI (ORCPT ); Fri, 13 Aug 2021 04:51:08 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:38748 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239436AbhHMIvH (ORCPT ); Fri, 13 Aug 2021 04:51:07 -0400 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 17D8gbVl065591; Fri, 13 Aug 2021 04:50:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=pp1; bh=6sdO162hVNmxVPJGQisEY8g8iYw9Fjx9nTXyNJLHdwc=; b=R8fZBsysSwPtyVPzNe3aqy8ZmSKsQlGEPb0oa5cHFskMajINcW3ESYRqYzksSOs6dPGW aby0KmEIpgMYSx9ViSbH3eQ6uihUjKM7UgPBO7BmtrYOE/BeS9Svz1jBP1cKWzgpNP/T o7eJZqdDnZ28QaOBpFEHkWbFGf7lKjSGHJZZR/hrQqOFh6vR529DnC1UkzWmIk6M9Ypq dvWPtnVuPiqGKsimsqee63g2iixxPov2TG5KJFV/VWlB4SpaH1IQsLdmH+SKGpaXiuDY p73KRuJYGx9XHoyyOaeCy9cqJFj7J7n7KaTMGrYhNXQTfJ2VhDqUTcbz4sxnbFs8El0X hA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3ad0qytheg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Aug 2021 04:50:41 -0400 Received: from m0098409.ppops.net (m0098409.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 17D8gqJo071392; Fri, 13 Aug 2021 04:50:40 -0400 Received: from ppma05fra.de.ibm.com (6c.4a.5195.ip4.static.sl-reverse.com [149.81.74.108]) by mx0a-001b2d01.pphosted.com with ESMTP id 3ad0qythdx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Aug 2021 04:50:40 -0400 Received: from pps.filterd (ppma05fra.de.ibm.com [127.0.0.1]) by ppma05fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 17D8lhNT006045; Fri, 13 Aug 2021 08:50:38 GMT Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by ppma05fra.de.ibm.com with ESMTP id 3a9ht9292a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Aug 2021 08:50:38 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 17D8oaNO56688952 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 13 Aug 2021 08:50:36 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0CDCD52071; Fri, 13 Aug 2021 08:50:36 +0000 (GMT) Received: from p-imbrenda (unknown [9.145.9.6]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id C595D5205F; Fri, 13 Aug 2021 08:50:35 +0000 (GMT) Date: Fri, 13 Aug 2021 10:40:17 +0200 From: Claudio Imbrenda To: Janosch Frank Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, david@redhat.com, thuth@redhat.com, cohuck@redhat.com Subject: Re: [kvm-unit-tests PATCH 3/8] lib: s390x: Print addressing related exception information Message-ID: <20210813104017.6e669d72@p-imbrenda> In-Reply-To: <20210813073615.32837-4-frankja@linux.ibm.com> References: <20210813073615.32837-1-frankja@linux.ibm.com> <20210813073615.32837-4-frankja@linux.ibm.com> Organization: IBM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: J8Yx3vcvqRybUnqshp0vJdJCksQA6LjU X-Proofpoint-ORIG-GUID: eUxQ8i7SzeymuijrYxmAz2sjL4yvNzcE X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-08-13_01:2021-08-12,2021-08-13 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 mlxlogscore=999 lowpriorityscore=0 suspectscore=0 clxscore=1015 phishscore=0 impostorscore=0 mlxscore=0 bulkscore=0 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2108130050 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, 13 Aug 2021 07:36:10 +0000 Janosch Frank wrote: > Right now we only get told the kind of program exception as well as > the PSW at the point where it happened. > > For addressing exceptions the PSW is not always enough so let's print > the TEID which contains the failing address and flags that tell us > more about the kind of address exception. > > Signed-off-by: Janosch Frank > --- > lib/s390x/asm/arch_def.h | 4 +++ > lib/s390x/interrupt.c | 72 > ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 76 > insertions(+) > > diff --git a/lib/s390x/asm/arch_def.h b/lib/s390x/asm/arch_def.h > index 4ca02c1d..39c5ba99 100644 > --- a/lib/s390x/asm/arch_def.h > +++ b/lib/s390x/asm/arch_def.h > @@ -41,6 +41,10 @@ struct psw { > uint64_t addr; > }; > > +/* Let's ignore spaces we don't expect to use for now. */ > +#define AS_PRIM 0 > +#define AS_HOME 3 > + > #define PSW_MASK_EXT 0x0100000000000000UL > #define PSW_MASK_IO 0x0200000000000000UL > #define PSW_MASK_DAT 0x0400000000000000UL > diff --git a/lib/s390x/interrupt.c b/lib/s390x/interrupt.c > index 01ded49d..1248bceb 100644 > --- a/lib/s390x/interrupt.c > +++ b/lib/s390x/interrupt.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > > static bool pgm_int_expected; > static bool ext_int_expected; > @@ -126,6 +127,73 @@ static void fixup_pgm_int(struct stack_frame_int > *stack) /* suppressed/terminated/completed point already at the next > address */ } > > +static void decode_pgm_prot(uint64_t teid) it is actually more complicated than this. if you don't want to add all the possibilities because they are unlikely and/or not relevant, maybe add a comment > +{ > + /* Low-address protection exception, 100 */ > + if (test_bit_inv(56, &teid) && !test_bit_inv(60, &teid) && > !test_bit_inv(61, &teid)) { > + printf("Type: LAP\n"); > + return; > + } > + > + /* Instruction execution prevention, i.e. no-execute, 101 */ > + if (test_bit_inv(56, &teid) && !test_bit_inv(60, &teid) && > test_bit_inv(61, &teid)) { > + printf("Type: IEP\n"); > + return; > + } > + > + /* Standard DAT exception, 001 */ > + if (!test_bit_inv(56, &teid) && !test_bit_inv(60, &teid) && > test_bit_inv(61, &teid)) { > + printf("Type: DAT\n"); > + return; > + } > +} > + > +static void decode_teid(uint64_t teid) > +{ > + int asce_id = lc->trans_exc_id & 3; > + bool dat = lc->pgm_old_psw.mask & PSW_MASK_DAT; > + > + printf("Memory exception information:\n"); > + printf("TEID: %lx\n", teid); > + printf("DAT: %s\n", dat ? "on" : "off"); > + printf("AS: %s\n", asce_id == AS_PRIM ? "Primary" : "Home"); > + > + if (lc->pgm_int_code == PGM_INT_CODE_PROTECTION) > + decode_pgm_prot(teid); > + > + /* > + * If teid bit 61 is off for these two exception the reported > + * address is unpredictable. > + */ > + if ((lc->pgm_int_code == PGM_INT_CODE_SECURE_STOR_ACCESS || > + lc->pgm_int_code == PGM_INT_CODE_SECURE_STOR_VIOLATION) > && > + !test_bit_inv(61, &teid)) { > + printf("Address: %lx, unpredictable\n ", teid & > PAGE_MASK); > + return; > + } > + printf("Address: %lx\n\n", teid & PAGE_MASK); > +} > + > +static void print_storage_exception_information(void) > +{ > + switch (lc->pgm_int_code) { > + case PGM_INT_CODE_PROTECTION: > + case PGM_INT_CODE_PAGE_TRANSLATION: > + case PGM_INT_CODE_SEGMENT_TRANSLATION: > + case PGM_INT_CODE_ASCE_TYPE: > + case PGM_INT_CODE_REGION_FIRST_TRANS: > + case PGM_INT_CODE_REGION_SECOND_TRANS: > + case PGM_INT_CODE_REGION_THIRD_TRANS: > + case PGM_INT_CODE_SECURE_STOR_ACCESS: > + case PGM_INT_CODE_NON_SECURE_STOR_ACCESS: > + case PGM_INT_CODE_SECURE_STOR_VIOLATION: > + decode_teid(lc->trans_exc_id); > + break; > + default: > + return; > + } > +} > + > static void print_int_regs(struct stack_frame_int *stack) > { > printf("\n"); > @@ -155,6 +223,10 @@ static void print_pgm_info(struct > stack_frame_int *stack) lc->pgm_int_code, stap(), > lc->pgm_old_psw.addr, lc->pgm_int_id); print_int_regs(stack); > dump_stack(); > + > + /* Dump stack doesn't end with a \n so we add it here > instead */ > + printf("\n"); > + print_storage_exception_information(); > report_summary(); > abort(); > }