public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: Janosch Frank <frankja@linux.ibm.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
	david@redhat.com, thuth@redhat.com, cohuck@redhat.com
Subject: Re: [kvm-unit-tests PATCH 8/8] lib: s390x: uv: Add rc 0x100 query error handling
Date: Fri, 13 Aug 2021 10:50:25 +0200	[thread overview]
Message-ID: <20210813105025.4eeada04@p-imbrenda> (raw)
In-Reply-To: <20210813073615.32837-9-frankja@linux.ibm.com>

On Fri, 13 Aug 2021 07:36:15 +0000
Janosch Frank <frankja@linux.ibm.com> wrote:

> Let's not get bitten by an extension of the query struct and handle
> the rc 0x100 error properly which does indicate that the UV has more
> data for us.
> 
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>

Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>

> ---
>  lib/s390x/uv.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/s390x/uv.c b/lib/s390x/uv.c
> index fd9de944..c5c69c47 100644
> --- a/lib/s390x/uv.c
> +++ b/lib/s390x/uv.c
> @@ -49,6 +49,8 @@ int uv_setup(void)
>  	if (!test_facility(158))
>  		return 0;
>  
> -	assert(!uv_call(0, (u64)&uvcb_qui));
> +	uv_call(0, (u64)&uvcb_qui);
> +
> +	assert(uvcb_qui.header.rc == 1 || uvcb_qui.header.rc ==
> 0x100); return 1;
>  }


  reply	other threads:[~2021-08-13  8:50 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-13  7:36 [kvm-unit-tests PATCH 0/8] s390x: Cleanup and maintenance Janosch Frank
2021-08-13  7:36 ` [kvm-unit-tests PATCH 1/8] s390x: lib: Extend bitops Janosch Frank
2021-08-13  8:32   ` Claudio Imbrenda
2021-08-13 11:31     ` Janosch Frank
2021-08-18  8:20       ` Thomas Huth
2021-08-18  8:39         ` Janosch Frank
2021-08-18  8:57           ` Thomas Huth
2021-08-13  7:36 ` [kvm-unit-tests PATCH 2/8] lib: s390x: Add 0x3d, 0x3e and 0x3f PGM constants Janosch Frank
2021-08-13  8:20   ` Claudio Imbrenda
2021-08-13  7:36 ` [kvm-unit-tests PATCH 3/8] lib: s390x: Print addressing related exception information Janosch Frank
2021-08-13  8:40   ` Claudio Imbrenda
2021-08-13 11:34     ` Janosch Frank
2021-08-18  9:12   ` Thomas Huth
2021-08-18  9:29     ` Claudio Imbrenda
2021-08-18  9:53     ` Janosch Frank
2021-08-13  7:36 ` [kvm-unit-tests PATCH 4/8] lib: s390x: Start using bitops instead of magic constants Janosch Frank
2021-08-13  8:41   ` Claudio Imbrenda
2021-08-18  9:24   ` Thomas Huth
2021-08-13  7:36 ` [kvm-unit-tests PATCH 5/8] s390x: uv-host: Explain why we set up the home space and remove the space change Janosch Frank
2021-08-13  8:45   ` Claudio Imbrenda
2021-08-13 13:14     ` Janosch Frank
2021-08-13  7:36 ` [kvm-unit-tests PATCH 6/8] lib: s390x: Add PSW_MASK_64 Janosch Frank
2021-08-13  8:46   ` Claudio Imbrenda
2021-08-18  9:28   ` Thomas Huth
2021-08-13  7:36 ` [kvm-unit-tests PATCH 7/8] lib: s390x: Control register constant cleanup Janosch Frank
2021-08-13  8:49   ` Claudio Imbrenda
2021-08-13  9:09     ` Janosch Frank
2021-08-13  7:36 ` [kvm-unit-tests PATCH 8/8] lib: s390x: uv: Add rc 0x100 query error handling Janosch Frank
2021-08-13  8:50   ` Claudio Imbrenda [this message]
2021-08-18  9:30   ` Thomas Huth
2021-08-18  9:57     ` Janosch Frank

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210813105025.4eeada04@p-imbrenda \
    --to=imbrenda@linux.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox