From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kvm-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,
	USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 76334C4338F
	for <kvm@archiver.kernel.org>; Wed, 25 Aug 2021 05:35:52 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 50AF16128A
	for <kvm@archiver.kernel.org>; Wed, 25 Aug 2021 05:35:52 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232321AbhHYFgg (ORCPT <rfc822;kvm@archiver.kernel.org>);
        Wed, 25 Aug 2021 01:36:36 -0400
Received: from verein.lst.de ([213.95.11.211]:54768 "EHLO verein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S232427AbhHYFge (ORCPT <rfc822;kvm@vger.kernel.org>);
        Wed, 25 Aug 2021 01:36:34 -0400
Received: by verein.lst.de (Postfix, from userid 2407)
        id 7E4426736F; Wed, 25 Aug 2021 07:35:47 +0200 (CEST)
Date:   Wed, 25 Aug 2021 07:35:47 +0200
From:   Christoph Hellwig <hch@lst.de>
To:     Jason Gunthorpe <jgg@ziepe.ca>
Cc:     Christoph Hellwig <hch@lst.de>,
        Alex Williamson <alex.williamson@redhat.com>,
        Diana Craciun <diana.craciun@oss.nxp.com>,
        Cornelia Huck <cohuck@redhat.com>,
        Kirti Wankhede <kwankhede@nvidia.com>,
        Eric Auger <eric.auger@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH 13/14] vfio/iommu_type1: remove the "external" domain
Message-ID: <20210825053547.GD26806@lst.de>
References: <20210824144649.1488190-1-hch@lst.de> <20210824144649.1488190-14-hch@lst.de> <20210825003629.GT543798@ziepe.ca>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210825003629.GT543798@ziepe.ca>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk
List-ID: <kvm.vger.kernel.org>
X-Mailing-List: kvm@vger.kernel.org

On Tue, Aug 24, 2021 at 09:36:29PM -0300, Jason Gunthorpe wrote:
> > +	/*
> > +	 * Tracks the fake iommu groups created by vfio to support mediated
> > +	 * devices.  These are not backed by an actual IOMMU.
> > +	 */
> > +	struct list_head	mediated_groups;
> 
> Though again I'd prefer another name to mediated here.. These are
> domainless groups?

I think they should use whatever named we use for/instead of the mediated
groups as these are the same concept.  Using an unrelated name like
external did causes major confusion.