From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kvm-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,
	USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id E1E15C432BE
	for <kvm@archiver.kernel.org>; Thu, 26 Aug 2021 08:22:04 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id C3F4D60C51
	for <kvm@archiver.kernel.org>; Thu, 26 Aug 2021 08:22:04 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S240476AbhHZIWu (ORCPT <rfc822;kvm@archiver.kernel.org>);
        Thu, 26 Aug 2021 04:22:50 -0400
Received: from verein.lst.de ([213.95.11.211]:58505 "EHLO verein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S240315AbhHZIWu (ORCPT <rfc822;kvm@vger.kernel.org>);
        Thu, 26 Aug 2021 04:22:50 -0400
Received: by verein.lst.de (Postfix, from userid 2407)
        id 3204567373; Thu, 26 Aug 2021 10:22:00 +0200 (CEST)
Date:   Thu, 26 Aug 2021 10:21:59 +0200
From:   Christoph Hellwig <hch@lst.de>
To:     "Tian, Kevin" <kevin.tian@intel.com>
Cc:     Christoph Hellwig <hch@lst.de>,
        Alex Williamson <alex.williamson@redhat.com>,
        Diana Craciun <diana.craciun@oss.nxp.com>,
        Cornelia Huck <cohuck@redhat.com>,
        Kirti Wankhede <kwankhede@nvidia.com>,
        Eric Auger <eric.auger@redhat.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        Jason Gunthorpe <jgg@nvidia.com>
Subject: Re: [PATCH 01/14] vfio: Move vfio_iommu_group_get() to
 vfio_register_group_dev()
Message-ID: <20210826082159.GA23444@lst.de>
References: <20210825161916.50393-1-hch@lst.de> <20210825161916.50393-2-hch@lst.de> <BN9PR11MB54333E1472046CD30F3EFE5C8CC79@BN9PR11MB5433.namprd11.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BN9PR11MB54333E1472046CD30F3EFE5C8CC79@BN9PR11MB5433.namprd11.prod.outlook.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk
List-ID: <kvm.vger.kernel.org>
X-Mailing-List: kvm@vger.kernel.org

On Thu, Aug 26, 2021 at 01:40:00AM +0000, Tian, Kevin wrote:
> > group %d\n",
> >  			 iommu_group_id(iommu_group));
> >  		vfio_device_put(existing_device);
> > -		vfio_group_put(group);
> > +		vfio_iommu_group_put(iommu_group, device->dev);
> 
> semantics change? the removed line is about vfio_group instead of
> iommu_group.

> > -	/* Matches the get in vfio_register_group_dev() */
> > -	vfio_group_put(group);
> > +	vfio_iommu_group_put(group->iommu_group, device->dev);
> 
> ditto

Yes, rebase/merge error.