From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, Sean Christopherson <seanjc@google.com>,
Bill Wendling <morbo@google.com>
Subject: [kvm-unit-tests PATCH v3 4/7] x86: realmode: mark exec_in_big_real_mode as noinline
Date: Thu, 9 Sep 2021 11:32:04 -0700 [thread overview]
Message-ID: <20210909183207.2228273-5-seanjc@google.com> (raw)
In-Reply-To: <20210909183207.2228273-1-seanjc@google.com>
From: Bill Wendling <morbo@google.com>
exec_in_big_real_mode() uses inline asm that defines labels that are
globally. Clang decides that it can inline this function, which causes the
assembler to complain about duplicate symbols. Mark the function as
"noinline" to prevent this.
Signed-off-by: Bill Wendling <morbo@google.com>
[sean: use noinline from compiler.h, call out the globally visible aspect]
Signed-off-by: Sean Christopherson <seanjc@google.com>
---
x86/realmode.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/x86/realmode.c b/x86/realmode.c
index b4fa603..7a4423e 100644
--- a/x86/realmode.c
+++ b/x86/realmode.c
@@ -1,3 +1,5 @@
+#include <linux/compiler.h>
+
#ifndef USE_SERIAL
#define USE_SERIAL
#endif
@@ -178,7 +180,7 @@ static inline void init_inregs(struct regs *regs)
inregs.esp = (unsigned long)&tmp_stack.top;
}
-static void exec_in_big_real_mode(struct insn_desc *insn)
+static noinline void exec_in_big_real_mode(struct insn_desc *insn)
{
unsigned long tmp;
static struct regs save;
--
2.33.0.309.g3052b89438-goog
next prev parent reply other threads:[~2021-09-09 18:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 18:32 [kvm-unit-tests PATCH v3 0/7] x86: Fix duplicate symbols w/ clang Sean Christopherson
2021-09-09 18:32 ` [kvm-unit-tests PATCH v3 1/7] lib: Drop x86/processor.h's barrier() in favor of compiler.h version Sean Christopherson
2021-09-09 18:41 ` Jim Mattson
2021-09-09 18:32 ` [kvm-unit-tests PATCH v3 2/7] lib: define the "noinline" macro Sean Christopherson
2021-09-09 18:42 ` Jim Mattson
2021-09-09 18:32 ` [kvm-unit-tests PATCH v3 3/7] lib: Move __unused attribute macro to compiler.h Sean Christopherson
2021-09-09 18:43 ` Jim Mattson
2021-09-09 18:32 ` Sean Christopherson [this message]
2021-09-09 18:45 ` [kvm-unit-tests PATCH v3 4/7] x86: realmode: mark exec_in_big_real_mode as noinline Jim Mattson
2021-09-09 18:32 ` [kvm-unit-tests PATCH v3 5/7] x86: svm: mark test_run " Sean Christopherson
2021-09-09 18:46 ` Jim Mattson
2021-09-09 18:32 ` [kvm-unit-tests PATCH v3 6/7] x86: umip: mark do_ring3 " Sean Christopherson
2021-09-09 18:47 ` Jim Mattson
2021-09-09 18:32 ` [kvm-unit-tests PATCH v3 7/7] x86: vmx: mark some test_* functions " Sean Christopherson
2021-09-09 18:52 ` Jim Mattson
2021-09-20 13:31 ` [kvm-unit-tests PATCH v3 0/7] x86: Fix duplicate symbols w/ clang Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210909183207.2228273-5-seanjc@google.com \
--to=seanjc@google.com \
--cc=kvm@vger.kernel.org \
--cc=morbo@google.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox