From: Kai Huang <kai.huang@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
x86@kernel.org, linux-sgx@vger.kernel.org, jarkko@kernel.org,
dave.hansen@linux.intel.com, yang.zhong@intel.com
Subject: Re: [PATCH 2/2] x86: sgx_vepc: implement SGX_IOC_VEPC_REMOVE ioctl
Date: Tue, 14 Sep 2021 22:55:08 +1200 [thread overview]
Message-ID: <20210914225508.032db86d89e6d207789ec1ea@intel.com> (raw)
In-Reply-To: <20210913131153.1202354-3-pbonzini@redhat.com>
On Mon, 13 Sep 2021 09:11:53 -0400 Paolo Bonzini wrote:
> Windows expects all pages to be in uninitialized state on startup.
> Add a ioctl that does this with EREMOVE, so that userspace can bring
> the pages back to this state also when resetting the VM.
> Pure userspace implementations, such as closing and reopening the device,
> are racy.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> arch/x86/include/uapi/asm/sgx.h | 2 ++
> arch/x86/kernel/cpu/sgx/virt.c | 36 +++++++++++++++++++++++++++++++++
> 2 files changed, 38 insertions(+)
>
> diff --git a/arch/x86/include/uapi/asm/sgx.h b/arch/x86/include/uapi/asm/sgx.h
> index 9690d6899ad9..f79d84ce8033 100644
> --- a/arch/x86/include/uapi/asm/sgx.h
> +++ b/arch/x86/include/uapi/asm/sgx.h
> @@ -27,6 +27,8 @@ enum sgx_page_flags {
> _IOW(SGX_MAGIC, 0x02, struct sgx_enclave_init)
> #define SGX_IOC_ENCLAVE_PROVISION \
> _IOW(SGX_MAGIC, 0x03, struct sgx_enclave_provision)
> +#define SGX_IOC_VEPC_REMOVE \
> + _IO(SGX_MAGIC, 0x04)
Perhaps SGX_IOC_VEPC_RESET is better than REMOVE, since this ioctl doesn't
actually remove any EPC page from virtual EPC device, but just reset to a clean
slate (by using EREMOVE).
next prev parent reply other threads:[~2021-09-14 10:55 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 13:11 [RFC/RFT PATCH 0/2] x86: sgx_vepc: implement ioctl to EREMOVE all pages Paolo Bonzini
2021-09-13 13:11 ` [PATCH 1/2] x86: sgx_vepc: extract sgx_vepc_remove_page Paolo Bonzini
2021-09-13 14:05 ` Dave Hansen
2021-09-13 14:24 ` Paolo Bonzini
2021-09-13 14:55 ` Dave Hansen
2021-09-13 15:14 ` Paolo Bonzini
2021-09-13 15:29 ` Dave Hansen
2021-09-13 18:35 ` Paolo Bonzini
2021-09-13 19:25 ` Dave Hansen
2021-09-13 21:16 ` Jarkko Sakkinen
2021-09-13 21:15 ` Jarkko Sakkinen
2021-09-13 21:13 ` Jarkko Sakkinen
2021-09-14 5:36 ` Paolo Bonzini
2021-09-14 16:05 ` Jarkko Sakkinen
2021-09-13 21:12 ` Jarkko Sakkinen
2021-09-13 21:00 ` Jarkko Sakkinen
2021-09-13 20:33 ` Jarkko Sakkinen
2021-09-13 13:11 ` [PATCH 2/2] x86: sgx_vepc: implement SGX_IOC_VEPC_REMOVE ioctl Paolo Bonzini
2021-09-13 19:33 ` Dave Hansen
2021-09-13 21:11 ` Sean Christopherson
2021-09-13 22:43 ` Dave Hansen
2021-09-14 10:55 ` Kai Huang [this message]
2021-09-14 7:10 ` [RFC/RFT PATCH 0/2] x86: sgx_vepc: implement ioctl to EREMOVE all pages Yang Zhong
2021-09-14 10:19 ` Paolo Bonzini
2021-09-14 16:42 ` Jarkko Sakkinen
2021-09-14 17:07 ` Paolo Bonzini
2021-09-14 17:40 ` Jarkko Sakkinen
2021-09-14 17:44 ` Jarkko Sakkinen
2021-09-15 8:28 ` Yang Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210914225508.032db86d89e6d207789ec1ea@intel.com \
--to=kai.huang@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=jarkko@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=x86@kernel.org \
--cc=yang.zhong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox