public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Janosch Frank <frankja@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: thuth@redhat.com, david@redhat.com, linux-s390@vger.kernel.org,
	seiden@linux.ibm.com, imbrenda@linux.ibm.com
Subject: [kvm-unit-tests PATCH 4/9] lib: s390x: uv: Fix share return value and print
Date: Wed, 22 Sep 2021 07:18:06 +0000	[thread overview]
Message-ID: <20210922071811.1913-5-frankja@linux.ibm.com> (raw)
In-Reply-To: <20210922071811.1913-1-frankja@linux.ibm.com>

Let's only return 0/1 for success/failure respectively.
If needed we can later add rc/rrc pointers so we can check for the
reasons of cc==1 cases like we do in the kernel.

As share might also be used in snippets it's best not to use prints to
avoid linking problems so lets remove the report_info().

Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
---
 lib/s390x/asm/uv.h | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/lib/s390x/asm/uv.h b/lib/s390x/asm/uv.h
index ec10d1c4..2f099553 100644
--- a/lib/s390x/asm/uv.h
+++ b/lib/s390x/asm/uv.h
@@ -219,15 +219,8 @@ static inline int share(unsigned long addr, u16 cmd)
 		.header.len = sizeof(uvcb),
 		.paddr = addr
 	};
-	int cc;
 
-	cc = uv_call(0, (u64)&uvcb);
-	if (!cc && uvcb.header.rc == UVC_RC_EXECUTED)
-		return 0;
-
-	report_info("uv_call: cmd %04x cc %d response code: %04x", cc, cmd,
-		    uvcb.header.rc);
-	return -1;
+	return uv_call(0, (u64)&uvcb);
 }
 
 /*
-- 
2.30.2


  parent reply	other threads:[~2021-09-22  7:19 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-22  7:18 [kvm-unit-tests PATCH 0/9] s390x: Cleanup and maintenance 2 Janosch Frank
2021-09-22  7:18 ` [kvm-unit-tests PATCH 1/9] s390x: uv: Tolerate 0x100 query return code Janosch Frank
2021-09-22  9:12   ` Claudio Imbrenda
2021-09-22 11:36     ` Janosch Frank
2021-09-27 15:19       ` Thomas Huth
2021-09-22  7:18 ` [kvm-unit-tests PATCH 2/9] s390x: pfmf: Fix 1MB handling Janosch Frank
2021-09-22  9:16   ` Claudio Imbrenda
2021-09-27 15:23   ` Thomas Huth
2021-09-28  9:50     ` Janosch Frank
2021-09-22  7:18 ` [kvm-unit-tests PATCH 3/9] s390x: uv-host: Fence a destroy cpu test on z15 Janosch Frank
2021-09-22  9:18   ` Claudio Imbrenda
2021-09-27 15:26   ` Thomas Huth
2021-09-28 11:21     ` Janosch Frank
2021-09-28 16:28       ` Thomas Huth
2021-09-22  7:18 ` Janosch Frank [this message]
2021-09-22  9:19   ` [kvm-unit-tests PATCH 4/9] lib: s390x: uv: Fix share return value and print Claudio Imbrenda
2021-09-27 17:38   ` Thomas Huth
2021-09-22  7:18 ` [kvm-unit-tests PATCH 5/9] lib: s390x: uv: Add UVC_ERR_DEBUG switch Janosch Frank
2021-09-22  9:23   ` Claudio Imbrenda
2021-09-22 11:37     ` Janosch Frank
2021-09-27 17:41   ` Thomas Huth
2021-09-28 10:00     ` Janosch Frank
2021-09-22  7:18 ` [kvm-unit-tests PATCH 6/9] lib: s390x: Print PGM code as hex Janosch Frank
2021-09-22  9:24   ` Claudio Imbrenda
2021-09-27 17:43   ` Thomas Huth
2021-09-22  7:18 ` [kvm-unit-tests PATCH 7/9] s390x: Makefile: Remove snippet flatlib linking Janosch Frank
2021-09-27 17:47   ` Thomas Huth
2021-09-28  9:57     ` Janosch Frank
2021-09-22  7:18 ` [kvm-unit-tests PATCH 8/9] s390x: Add sthyi cc==0 r2+1 verification Janosch Frank
2021-09-22  9:31   ` Claudio Imbrenda
2021-09-22  7:18 ` [kvm-unit-tests PATCH 9/9] s390x: skrf: Fix tprot assembly Janosch Frank
2021-09-22  9:34   ` Claudio Imbrenda
2021-09-22 11:47     ` Janosch Frank
     [not found]   ` <20210922134112.174842-1-scgl@linux.ibm.com>
2021-09-22 13:53     ` Janosch Frank

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210922071811.1913-5-frankja@linux.ibm.com \
    --to=frankja@linux.ibm.com \
    --cc=david@redhat.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=seiden@linux.ibm.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox