public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Janosch Frank <frankja@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: thuth@redhat.com, david@redhat.com, linux-s390@vger.kernel.org,
	seiden@linux.ibm.com, imbrenda@linux.ibm.com
Subject: [kvm-unit-tests PATCH 8/9] s390x: Add sthyi cc==0 r2+1 verification
Date: Wed, 22 Sep 2021 07:18:10 +0000	[thread overview]
Message-ID: <20210922071811.1913-9-frankja@linux.ibm.com> (raw)
In-Reply-To: <20210922071811.1913-1-frankja@linux.ibm.com>

On success r2 + 1 should be 0, let's also check for that.

Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
---
 s390x/sthyi.c | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/s390x/sthyi.c b/s390x/sthyi.c
index db90b56f..4b153bf4 100644
--- a/s390x/sthyi.c
+++ b/s390x/sthyi.c
@@ -24,16 +24,16 @@ static inline int sthyi(uint64_t vaddr, uint64_t fcode, uint64_t *rc,
 {
 	register uint64_t code asm("0") = fcode;
 	register uint64_t addr asm("2") = vaddr;
-	register uint64_t rc3 asm("3") = 0;
+	register uint64_t rc3 asm("3") = 42;
 	int cc = 0;
 
-	asm volatile(".insn rre,0xB2560000,%[r1],%[r2]\n"
-		     "ipm	 %[cc]\n"
-		     "srl	 %[cc],28\n"
-		     : [cc] "=d" (cc)
-		     : [code] "d" (code), [addr] "a" (addr), [r1] "i" (r1),
-		       [r2] "i" (r2)
-		     : "memory", "cc", "r3");
+	asm volatile(
+		".insn   rre,0xB2560000,%[r1],%[r2]\n"
+		"ipm     %[cc]\n"
+		"srl     %[cc],28\n"
+		: [cc] "=d" (cc), "+d" (rc3)
+		: [code] "d" (code), [addr] "a" (addr), [r1] "i" (r1), [r2] "i" (r2)
+		: "memory", "cc");
 	if (rc)
 		*rc = rc3;
 	return cc;
@@ -139,16 +139,18 @@ static void test_fcode0(void)
 	struct sthyi_hdr_sctn *hdr;
 	struct sthyi_mach_sctn *mach;
 	struct sthyi_par_sctn *par;
+	uint64_t rc = 42;
 
 	/* Zero destination memory. */
 	memset(pagebuf, 0, PAGE_SIZE);
 
 	report_prefix_push("fcode 0");
-	sthyi((uint64_t)pagebuf, 0, NULL, 0, 2);
+	sthyi((uint64_t)pagebuf, 0, &rc, 0, 2);
 	hdr = (void *)pagebuf;
 	mach = (void *)pagebuf + hdr->INFMOFF;
 	par = (void *)pagebuf + hdr->INFPOFF;
 
+	report(!rc, "r2 + 1 == 0");
 	test_fcode0_hdr(hdr);
 	test_fcode0_mach(mach);
 	test_fcode0_par(par);
-- 
2.30.2


  parent reply	other threads:[~2021-09-22  7:19 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-22  7:18 [kvm-unit-tests PATCH 0/9] s390x: Cleanup and maintenance 2 Janosch Frank
2021-09-22  7:18 ` [kvm-unit-tests PATCH 1/9] s390x: uv: Tolerate 0x100 query return code Janosch Frank
2021-09-22  9:12   ` Claudio Imbrenda
2021-09-22 11:36     ` Janosch Frank
2021-09-27 15:19       ` Thomas Huth
2021-09-22  7:18 ` [kvm-unit-tests PATCH 2/9] s390x: pfmf: Fix 1MB handling Janosch Frank
2021-09-22  9:16   ` Claudio Imbrenda
2021-09-27 15:23   ` Thomas Huth
2021-09-28  9:50     ` Janosch Frank
2021-09-22  7:18 ` [kvm-unit-tests PATCH 3/9] s390x: uv-host: Fence a destroy cpu test on z15 Janosch Frank
2021-09-22  9:18   ` Claudio Imbrenda
2021-09-27 15:26   ` Thomas Huth
2021-09-28 11:21     ` Janosch Frank
2021-09-28 16:28       ` Thomas Huth
2021-09-22  7:18 ` [kvm-unit-tests PATCH 4/9] lib: s390x: uv: Fix share return value and print Janosch Frank
2021-09-22  9:19   ` Claudio Imbrenda
2021-09-27 17:38   ` Thomas Huth
2021-09-22  7:18 ` [kvm-unit-tests PATCH 5/9] lib: s390x: uv: Add UVC_ERR_DEBUG switch Janosch Frank
2021-09-22  9:23   ` Claudio Imbrenda
2021-09-22 11:37     ` Janosch Frank
2021-09-27 17:41   ` Thomas Huth
2021-09-28 10:00     ` Janosch Frank
2021-09-22  7:18 ` [kvm-unit-tests PATCH 6/9] lib: s390x: Print PGM code as hex Janosch Frank
2021-09-22  9:24   ` Claudio Imbrenda
2021-09-27 17:43   ` Thomas Huth
2021-09-22  7:18 ` [kvm-unit-tests PATCH 7/9] s390x: Makefile: Remove snippet flatlib linking Janosch Frank
2021-09-27 17:47   ` Thomas Huth
2021-09-28  9:57     ` Janosch Frank
2021-09-22  7:18 ` Janosch Frank [this message]
2021-09-22  9:31   ` [kvm-unit-tests PATCH 8/9] s390x: Add sthyi cc==0 r2+1 verification Claudio Imbrenda
2021-09-22  7:18 ` [kvm-unit-tests PATCH 9/9] s390x: skrf: Fix tprot assembly Janosch Frank
2021-09-22  9:34   ` Claudio Imbrenda
2021-09-22 11:47     ` Janosch Frank
     [not found]   ` <20210922134112.174842-1-scgl@linux.ibm.com>
2021-09-22 13:53     ` Janosch Frank

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210922071811.1913-9-frankja@linux.ibm.com \
    --to=frankja@linux.ibm.com \
    --cc=david@redhat.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=seiden@linux.ibm.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox