From: Andrew Jones <drjones@redhat.com>
To: Marc Zyngier <maz@kernel.org>
Cc: qemu-devel@nongnu.org, Eric Auger <eric.auger@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
kernel-team@android.com
Subject: Re: [PATCH v2 5/5] hw/arm/virt: Disable highmem devices that don't fit in the PA range
Date: Mon, 4 Oct 2021 12:12:40 +0200 [thread overview]
Message-ID: <20211004101240.fdf2mty5jvnler33@gator> (raw)
In-Reply-To: <20211003164605.3116450-6-maz@kernel.org>
On Sun, Oct 03, 2021 at 05:46:05PM +0100, Marc Zyngier wrote:
> Make sure both the highmem PCIe and GICv3 regions are disabled when
> they don't fully fit in the PA range.
>
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> ---
> hw/arm/virt.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index a572e0c9d9..756f67b6c8 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -1673,6 +1673,9 @@ static void virt_set_memmap(VirtMachineState *vms, int pa_bits)
> if (base <= BIT_ULL(pa_bits)) {
> vms->highest_gpa = base -1;
> } else {
> + /* Advertise that we have disabled the highmem devices */
> + vms->highmem_ecam = false;
> + vms->highmem_redists = false;
> vms->highest_gpa = memtop - 1;
> }
>
> --
> 2.30.2
>
Reviewed-by: Andrew Jones <drjones@redhat.com>
prev parent reply other threads:[~2021-10-04 10:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 16:46 [PATCH v2 0/5] target/arm: Reduced-IPA space and highmem=off fixes Marc Zyngier
2021-10-03 16:46 ` [PATCH v2 1/5] hw/arm/virt: Key enablement of highmem PCIe on highmem_ecam Marc Zyngier
2021-10-04 9:41 ` Andrew Jones
2021-10-04 12:00 ` Eric Auger
2021-12-27 15:53 ` Marc Zyngier
2022-01-04 15:31 ` Eric Auger
2022-01-04 22:15 ` Marc Zyngier
2022-01-05 9:41 ` Eric Auger
2022-01-06 19:34 ` Marc Zyngier
2022-01-07 17:10 ` Eric Auger
2021-10-03 16:46 ` [PATCH v2 2/5] hw/arm/virt: Add a control for the the highmem redistributors Marc Zyngier
2021-10-04 9:44 ` Andrew Jones
2021-10-04 10:14 ` Andrew Jones
2021-10-03 16:46 ` [PATCH v2 3/5] hw/arm/virt: Honor highmem setting when computing the memory map Marc Zyngier
2021-10-04 9:44 ` Andrew Jones
2021-10-04 12:23 ` Eric Auger
2021-12-27 16:39 ` Marc Zyngier
2021-10-03 16:46 ` [PATCH v2 4/5] hw/arm/virt: Use the PA range to compute " Marc Zyngier
2021-10-04 10:11 ` Andrew Jones
2021-12-27 20:13 ` Marc Zyngier
2021-10-04 10:15 ` Andrew Jones
2021-10-03 16:46 ` [PATCH v2 5/5] hw/arm/virt: Disable highmem devices that don't fit in the PA range Marc Zyngier
2021-10-04 10:12 ` Andrew Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211004101240.fdf2mty5jvnler33@gator \
--to=drjones@redhat.com \
--cc=eric.auger@redhat.com \
--cc=kernel-team@android.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=maz@kernel.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox