Re: [kvm-unit-tests PATCH v2 0/5] Add specification exception tests

Thomas Huth
2021-10-05T16:10:04Z

On 05/10/2021 12.30, Janis Schoetterl-Glausch wrote:
> On Tue, Oct 05, 2021 at 11:13:22AM +0200, Thomas Huth wrote:
>> On 05/10/2021 11.09, Janis Schoetterl-Glausch wrote:
>>> Test that specification exceptions cause the correct interruption code
>>> during both normal and transactional execution.
>>>
>>> The last three patches are cosmetic only and could be dropped.
>>>
>>> Unrelated: There should not be * in the file patterns in MAINTAINERS,
>>> should there?
>>
>> I think those could be dropped, indeed. Care to send a patch?
>
> You mean the * patterns, not the cosmetic patches, correct?
>
> -- >8 --
> Subject: [kvm-unit-tests PATCH] MAINTAINERS: Include subdirectories in file
> patterns
>
> The * pattern does not cover subdirectories, so get_maintainer.pl does
> not know who maintains e.g. lib/<arch>/asm/*.
>
> Signed-off-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
> ---
> MAINTAINERS | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4fc01a5..15b5e1b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -68,9 +68,9 @@ M: Andrew Jones <drjones@redhat.com>
> S: Supported
> L: kvm@vger.kernel.org
> L: kvmarm@lists.cs.columbia.edu
> -F: arm/*
> -F: lib/arm/*
> -F: lib/arm64/*
> +F: arm/
> +F: lib/arm/
> +F: lib/arm64/
> T: https://gitlab.com/rhdrjones/kvm-unit-tests.git
>
> POWERPC
> @@ -79,9 +79,9 @@ M: Thomas Huth <thuth@redhat.com>
> S: Maintained
> L: kvm@vger.kernel.org
> L: kvm-ppc@vger.kernel.org
> -F: powerpc/*
> -F: lib/powerpc/*
> -F: lib/ppc64/*
> +F: powerpc/
> +F: lib/powerpc/
> +F: lib/ppc64/
>
> S390X
> M: Thomas Huth <thuth@redhat.com>
> @@ -92,13 +92,13 @@ R: Claudio Imbrenda <imbrenda@linux.ibm.com>
> R: David Hildenbrand <david@redhat.com>
> L: kvm@vger.kernel.org
> L: linux-s390@vger.kernel.org
> -F: s390x/*
> -F: lib/s390x/*
> +F: s390x/
> +F: lib/s390x/
>
> X86
> M: Paolo Bonzini <pbonzini@redhat.com>
> S: Supported
> L: kvm@vger.kernel.org
> -F: x86/*
> -F: lib/x86/*
> +F: x86/
> +F: lib/x86/
> T: https://gitlab.com/bonzini/kvm-unit-tests.git
>
> base-commit: fe26131eec769cef7ad7e2e1e4e192aa0bdb2bba
>

Thanks, applied.

Thomas