From: Eric Farman <farman@linux.ibm.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Jason Herne <jjherne@linux.ibm.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
Eric Farman <farman@linux.ibm.com>
Subject: [RFC PATCH v1 3/6] KVM: s390: Simplify SIGP Restart
Date: Fri, 8 Oct 2021 22:31:09 +0200 [thread overview]
Message-ID: <20211008203112.1979843-4-farman@linux.ibm.com> (raw)
In-Reply-To: <20211008203112.1979843-1-farman@linux.ibm.com>
Now that we check for the STOP IRQ injection at the top of the SIGP
handler (before the userspace/kernelspace check), we don't need to do
it down here for the Restart order.
Signed-off-by: Eric Farman <farman@linux.ibm.com>
---
arch/s390/kvm/sigp.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/arch/s390/kvm/sigp.c b/arch/s390/kvm/sigp.c
index 6ca01bbc72cf..0c08927ca7c9 100644
--- a/arch/s390/kvm/sigp.c
+++ b/arch/s390/kvm/sigp.c
@@ -240,17 +240,8 @@ static int __sigp_sense_running(struct kvm_vcpu *vcpu,
static int __prepare_sigp_re_start(struct kvm_vcpu *vcpu,
struct kvm_vcpu *dst_vcpu, u8 order_code)
{
- struct kvm_s390_local_interrupt *li = &dst_vcpu->arch.local_int;
/* handle (RE)START in user space */
- int rc = -EOPNOTSUPP;
-
- /* make sure we don't race with STOP irq injection */
- spin_lock(&li->lock);
- if (kvm_s390_is_stop_irq_pending(dst_vcpu))
- rc = SIGP_CC_BUSY;
- spin_unlock(&li->lock);
-
- return rc;
+ return -EOPNOTSUPP;
}
static int __prepare_sigp_cpu_reset(struct kvm_vcpu *vcpu,
--
2.25.1
next prev parent reply other threads:[~2021-10-08 20:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 20:31 [RFC PATCH v1 0/6] Improvements to SIGP handling [KVM] Eric Farman
2021-10-08 20:31 ` [RFC PATCH v1 1/6] KVM: s390: Simplify SIGP Set Arch handling Eric Farman
2021-10-11 6:29 ` Thomas Huth
2021-10-11 7:24 ` Christian Borntraeger
2021-10-11 17:57 ` David Hildenbrand
2021-10-12 7:35 ` Claudio Imbrenda
2021-10-12 8:42 ` Christian Borntraeger
2021-10-08 20:31 ` [RFC PATCH v1 2/6] KVM: s390: Reject SIGP when destination CPU is busy Eric Farman
2021-10-11 7:27 ` Thomas Huth
2021-10-11 7:43 ` Christian Borntraeger
2021-10-11 7:52 ` Thomas Huth
2021-10-11 17:58 ` David Hildenbrand
2021-10-11 18:13 ` Eric Farman
2021-10-08 20:31 ` Eric Farman [this message]
2021-10-11 7:45 ` [RFC PATCH v1 3/6] KVM: s390: Simplify SIGP Restart Christian Borntraeger
2021-10-12 15:23 ` Thomas Huth
2021-10-12 15:31 ` Eric Farman
2021-10-13 5:54 ` Thomas Huth
2021-10-13 13:54 ` Eric Farman
2021-10-08 20:31 ` [RFC PATCH v1 4/6] KVM: s390: Restart IRQ should also block SIGP Eric Farman
2021-10-08 20:31 ` [RFC PATCH v1 5/6] KVM: s390: Give BUSY to SIGP SENSE during Restart Eric Farman
2021-10-11 18:01 ` David Hildenbrand
2021-10-08 20:31 ` [RFC PATCH v1 6/6] KVM: s390: Add a routine for setting userspace CPU state Eric Farman
2021-10-11 7:31 ` Thomas Huth
2021-10-11 7:45 ` David Hildenbrand
2021-10-12 7:45 ` Claudio Imbrenda
2021-10-12 8:44 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211008203112.1979843-4-farman@linux.ibm.com \
--to=farman@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=jjherne@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox