Re: [PATCH v3 4/8] nSVM: use vmcb_save_area_cached in nested_vmcb_valid_sregs()

Emanuele Giuseppe Esposito
2021-10-22T13:48:31Z

On 22/10/2021 09:14, Paolo Bonzini wrote:
> On 11/10/21 16:36, Emanuele Giuseppe Esposito wrote:
>> +
>> +out_free_save:
>> +    memset(&svm->nested.save, 0, sizeof(struct vmcb_save_area_cached));
>> +
>
> This memset is not strictly necessary, is it?  (Same for out_free_ctl
> later on).
>

It was just to keep the struct clean in case of error, but
you are right, it can be removed.

Thank you,
Emanuele