[kvm-unit-tests GIT PULL 08/17] lib: s390x: uv: Fix share return value and print

Janosch Frank
2021-10-18T12:38:14Z

Let's only return 0/1 for success/failure respectively.
If needed we can later add rc/rrc pointers so we can check for the
reasons of cc==1 cases like we do in the kernel.

As share() might also be used in snippets it's best not to use prints
to avoid linking problems so lets remove the report_info().

Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Acked-by: Thomas Huth <thuth@redhat.com>
---
lib/s390x/asm/uv.h | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/lib/s390x/asm/uv.h b/lib/s390x/asm/uv.h
index ec10d1c4..2f099553 100644
--- a/lib/s390x/asm/uv.h
+++ b/lib/s390x/asm/uv.h
@@ -219,15 +219,8 @@ static inline int share(unsigned long addr, u16 cmd)
.header.len = sizeof(uvcb),
.paddr = addr
};
- int cc;

- cc = uv_call(0, (u64)&uvcb);
- if (!cc && uvcb.header.rc == UVC_RC_EXECUTED)
- return 0;
-
- report_info("uv_call: cmd %04x cc %d response code: %04x", cc, cmd,
- uvcb.header.rc);
- return -1;
+ return uv_call(0, (u64)&uvcb);
}

/*
--
2.31.1