From: Jason Gunthorpe <jgg@nvidia.com>
To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
Cc: Yishai Hadas <yishaih@nvidia.com>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"saeedm@nvidia.com" <saeedm@nvidia.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"kuba@kernel.org" <kuba@kernel.org>,
"leonro@nvidia.com" <leonro@nvidia.com>,
"kwankhede@nvidia.com" <kwankhede@nvidia.com>,
"mgurtovoy@nvidia.com" <mgurtovoy@nvidia.com>,
"maorg@nvidia.com" <maorg@nvidia.com>
Subject: Re: [PATCH V1 mlx5-next 11/13] vfio/mlx5: Implement vfio_pci driver for mlx5 devices
Date: Tue, 19 Oct 2021 08:24:20 -0300 [thread overview]
Message-ID: <20211019112420.GR2744544@nvidia.com> (raw)
In-Reply-To: <ed08f3350c594a63982856434d19d728@huawei.com>
On Tue, Oct 19, 2021 at 09:59:03AM +0000, Shameerali Kolothum Thodi wrote:
> > + /* Saving switches on */
> > + if ((old_state & VFIO_DEVICE_STATE_SAVING) !=
> > + (state & VFIO_DEVICE_STATE_SAVING) &&
> > + (state & VFIO_DEVICE_STATE_SAVING)) {
> > + if (!(state & VFIO_DEVICE_STATE_RUNNING)) {
> > + /* serialize post copy */
> > + ret = mlx5vf_pci_save_device_data(mvdev);
>
> Does it actually get into post-copy here? The pre-copy state(old_state)
> has the _SAVING bit set already and post-copy state( new state) also
> has _SAVING set. It looks like we need to handle the post copy in the above
> "Running switches off" and check for (state & _SAVING).
Right, if statements cannot be nested like this. Probably like this:
if ((new_state ^ old_state) & (VFIO_DEVICE_STATE_SAVING|VFIO_DEVICE_STATE_RUNNING) !=
(new_state & (VFIO_DEVICE_STATE_SAVING|VFIO_DEVICE_STATE_RUNNING)) == (VFIO_DEVICE_STATE_SAVING)
Jason
next prev parent reply other threads:[~2021-10-19 11:24 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 9:46 [PATCH V1 mlx5-next 00/13] Add mlx5 live migration driver Yishai Hadas
2021-10-13 9:46 ` [PATCH V1 mlx5-next 01/13] PCI/IOV: Provide internal VF index Yishai Hadas
2021-10-13 18:14 ` Bjorn Helgaas
2021-10-14 9:08 ` Yishai Hadas
2021-10-13 9:46 ` [PATCH V1 mlx5-next 02/13] net/mlx5: Reuse exported virtfn index function call Yishai Hadas
2021-10-13 9:46 ` [PATCH V1 mlx5-next 03/13] net/mlx5: Disable SRIOV before PF removal Yishai Hadas
2021-10-13 9:46 ` [PATCH V1 mlx5-next 04/13] PCI/IOV: Allow SRIOV VF drivers to reach the drvdata of a PF Yishai Hadas
2021-10-13 18:27 ` Bjorn Helgaas
2021-10-14 22:11 ` Alex Williamson
2021-10-17 13:43 ` Yishai Hadas
2021-10-13 9:46 ` [PATCH V1 mlx5-next 05/13] net/mlx5: Expose APIs to get/put the mlx5 core device Yishai Hadas
2021-10-13 9:47 ` [PATCH V1 mlx5-next 06/13] vdpa/mlx5: Use mlx5_vf_get_core_dev() to get PF device Yishai Hadas
2021-10-13 9:47 ` [PATCH V1 mlx5-next 07/13] vfio: Add 'invalid' state definitions Yishai Hadas
2021-10-15 16:38 ` Alex Williamson
2021-10-17 14:07 ` Yishai Hadas
2021-10-13 9:47 ` [PATCH V1 mlx5-next 08/13] vfio/pci_core: Make the region->release() function optional Yishai Hadas
2021-10-13 9:47 ` [PATCH V1 mlx5-next 09/13] net/mlx5: Introduce migration bits and structures Yishai Hadas
2021-10-13 9:47 ` [PATCH V1 mlx5-next 10/13] vfio/mlx5: Expose migration commands over mlx5 device Yishai Hadas
2021-10-13 9:47 ` [PATCH V1 mlx5-next 11/13] vfio/mlx5: Implement vfio_pci driver for mlx5 devices Yishai Hadas
2021-10-15 19:48 ` Alex Williamson
2021-10-15 19:59 ` Jason Gunthorpe
2021-10-15 20:12 ` Alex Williamson
2021-10-15 20:16 ` Jason Gunthorpe
2021-10-15 20:59 ` Alex Williamson
2021-10-17 14:03 ` Yishai Hadas
2021-10-18 11:51 ` Jason Gunthorpe
2021-10-18 13:26 ` Yishai Hadas
2021-10-18 13:42 ` Alex Williamson
2021-10-18 13:46 ` Yishai Hadas
2021-10-19 9:59 ` Shameerali Kolothum Thodi
2021-10-19 10:30 ` Yishai Hadas
2021-10-19 11:26 ` Shameerali Kolothum Thodi
2021-10-19 11:24 ` Jason Gunthorpe [this message]
2021-10-13 9:47 ` [PATCH V1 mlx5-next 12/13] vfio/pci: Add infrastructure to let vfio_pci_core drivers trap device RESET Yishai Hadas
2021-10-15 19:52 ` Alex Williamson
2021-10-15 20:03 ` Jason Gunthorpe
2021-10-15 21:12 ` Alex Williamson
2021-10-17 14:29 ` Yishai Hadas
2021-10-18 12:02 ` Jason Gunthorpe
2021-10-18 13:41 ` Yishai Hadas
2021-10-13 9:47 ` [PATCH V1 mlx5-next 13/13] vfio/mlx5: Trap device RESET and update state accordingly Yishai Hadas
2021-10-13 18:06 ` Jason Gunthorpe
2021-10-14 9:18 ` Yishai Hadas
2021-10-15 19:54 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211019112420.GR2744544@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-pci@vger.kernel.org \
--cc=maorg@nvidia.com \
--cc=mgurtovoy@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox