Re: [PATCH] x86/kvm: remove unused ack_notifier callbacks

Paolo Bonzini
2021-11-17T07:45:56Z

On 11/17/21 08:16, Juergen Gross wrote:
> Commit f52447261bc8c2 ("KVM: irq ack notification") introduced an
> ack_notifier() callback in struct kvm_pic and in struct kvm_ioapic
> without using them anywhere. Remove those callbacks again.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
> arch/x86/kvm/ioapic.h | 1 -
> arch/x86/kvm/irq.h | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/arch/x86/kvm/ioapic.h b/arch/x86/kvm/ioapic.h
> index 623a3c5afad7..5666c39d8df1 100644
> --- a/arch/x86/kvm/ioapic.h
> +++ b/arch/x86/kvm/ioapic.h
> @@ -81,7 +81,6 @@ struct kvm_ioapic {
> unsigned long irq_states[IOAPIC_NUM_PINS];
> struct kvm_io_device dev;
> struct kvm *kvm;
> - void (*ack_notifier)(void *opaque, int irq);
> spinlock_t lock;
> struct rtc_status rtc_status;
> struct delayed_work eoi_inject;
> diff --git a/arch/x86/kvm/irq.h b/arch/x86/kvm/irq.h
> index 650642b18d15..c2d7cfe82d00 100644
> --- a/arch/x86/kvm/irq.h
> +++ b/arch/x86/kvm/irq.h
> @@ -56,7 +56,6 @@ struct kvm_pic {
> struct kvm_io_device dev_master;
> struct kvm_io_device dev_slave;
> struct kvm_io_device dev_elcr;
> - void (*ack_notifier)(void *opaque, int irq);
> unsigned long irq_states[PIC_NUM_PINS];
> };
>
>

Nice. Queued, thanks.

Paolo