Re: [PATCH 02/15] KVM: VMX: Avoid to rdmsrl(MSR_IA32_SYSENTER_ESP)

Paolo Bonzini
2021-11-18T14:38:46Z

On 11/18/21 15:17, Lai Jiangshan wrote:
>
> The change in vmx_vcpu_load_vmcs() handles only the percpu constant case:
> (cpu_entry_stack(cpu) + 1), it doesn't handle the case where
> MSR_IA32_SYSENTER_ESP is NULL.
>
> The change in vmx_set_constant_host_state() handles the case where
> MSR_IA32_SYSENTER_ESP is NULL, it does be constant host state in this case.
> If it is not the case, the added code in vmx_vcpu_load_vmcs() will override
> it safely.
>
> If an else branch with "vmcs_writel(HOST_IA32_SYSENTER_ESP, 0);" is
> added to
> vmx_vcpu_load_vmcs(), we will not need to change
> vmx_set_constant_host_state().

We can change vmx_set_constant_host_state to write 0.

Paolo