Re: [PATCH 01/32] s390/sclp: detect the zPCI interpretation facility

Claudio Imbrenda
2021-12-08T14:12:48Z

On Tue, 7 Dec 2021 15:57:12 -0500
Matthew Rosato <mjrosato@linux.ibm.com> wrote:

> Detect the zPCI Load/Store Interpretation facility.
>
> Reviewed-by: Eric Farman <farman@linux.ibm.com>
> Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>

I have the same comment as Christian; with that fixed:

Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>

> ---
> arch/s390/include/asm/sclp.h | 1 +
> drivers/s390/char/sclp_early.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/arch/s390/include/asm/sclp.h b/arch/s390/include/asm/sclp.h
> index c68ea35de498..c84e8e0ca344 100644
> --- a/arch/s390/include/asm/sclp.h
> +++ b/arch/s390/include/asm/sclp.h
> @@ -88,6 +88,7 @@ struct sclp_info {
> unsigned char has_diag318 : 1;
> unsigned char has_sipl : 1;
> unsigned char has_dirq : 1;
> + unsigned char has_zpci_interp : 1;
> unsigned int ibc;
> unsigned int mtid;
> unsigned int mtid_cp;
> diff --git a/drivers/s390/char/sclp_early.c b/drivers/s390/char/sclp_early.c
> index b64feab62caa..2e8199b7ae50 100644
> --- a/drivers/s390/char/sclp_early.c
> +++ b/drivers/s390/char/sclp_early.c
> @@ -45,6 +45,7 @@ static void __init sclp_early_facilities_detect(void)
> sclp.has_gisaf = !!(sccb->fac118 & 0x08);
> sclp.has_hvs = !!(sccb->fac119 & 0x80);
> sclp.has_kss = !!(sccb->fac98 & 0x01);
> + sclp.has_zpci_interp = !!(sccb->fac118 & 0x01);
> if (sccb->fac85 & 0x02)
> S390_lowcore.machine_flags |= MACHINE_FLAG_ESOP;
> if (sccb->fac91 & 0x40)