From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sean Christopherson <seanjc@google.com>
Cc: kvm@vger.kernel.org
Subject: Re: [bug report] KVM: Dynamically allocate "new" memslots from the get-go
Date: Wed, 15 Dec 2021 21:11:02 +0300 [thread overview]
Message-ID: <20211215181102.GC1978@kadam> (raw)
In-Reply-To: <YboZE29SMR/EgLOL@google.com>
On Wed, Dec 15, 2021 at 04:34:27PM +0000, Sean Christopherson wrote:
> There's no true dereference, architectures are responsible for ensuring @old and
> @new are non-NULL, either via explicit checks on the pointer or implicit checks
> on @change.
Ah... Okay. Thanks.
Smatch tries to track these implicit checks within a function but the
relationships get lost at the function boundaries. So, for example, if
there were three callers and two were non-NULL and one was NULL then
Smatch could figure it out. But in this case there is only one caller
so the data gets squished together and the relationship between "change"
and "new" gets lost.
regards,
dan carpenter
prev parent reply other threads:[~2021-12-15 18:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 11:24 [bug report] KVM: Dynamically allocate "new" memslots from the get-go Dan Carpenter
2021-12-15 16:34 ` Sean Christopherson
2021-12-15 18:11 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211215181102.GC1978@kadam \
--to=dan.carpenter@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox