RE: [PATCH v6 19/21] kvm: selftests: Add support for KVM_CAP_XSAVE2

Wang, Wei W
2022-01-18T02:06:51Z

On Tuesday, January 18, 2022 12:51 AM, Janis Schoetterl-Glausch wrote:
> > + /*
> > + * Permission needs to be requested before KVM_SET_CPUID2.
> > + */
> > + vm_xsave_req_perm();
> > +
>
> Since
>
> 79e06c4c4950 (Merge tag 'for-linus' of
> git://git.kernel.org/pub/scm/virt/kvm/kvm)
>
> on s390x I'm getting:
>
> /usr/bin/ld: tools/testing/selftests/kvm/libkvm.a(kvm_util.o): in function
> `vm_create_with_vcpus':
> tools/testing/selftests/kvm/lib/kvm_util.c:399: undefined reference to
> `vm_xsave_req_perm'
> collect2: error: ld returned 1 exit status
> make: *** [../lib.mk:146: tools/testing/selftests/kvm/s390x/memop] Error 1
>
> Looks like it only exists for x86.
> v2 had a comment about unconditional enablement:
> https://lore.kernel.org/kvm/e20f590b-b9d9-237d-3b9c-77dd82a24b40@redh
> at.com/
>
> Thanks for having a look.
>

OK, we made it conditionally enabled at runtime, but this one requires conditionally compiled. I'll get you a patch to test soon.

Thanks,
Wei