From: Yang Zhong <yang.zhong@intel.com>
To: Sean Christopherson <seanjc@google.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, yang.zhong@intel.com
Subject: Re: [PATCH 1/2] kvm: selftests: Sync KVM_CAP_XSAVE2 from linux header
Date: Wed, 19 Jan 2022 09:51:53 +0800 [thread overview]
Message-ID: <20220119015153.GA24086@yangzhon-Virtual> (raw)
In-Reply-To: <Yebw2wQu4OuS0CB2@google.com>
On Tue, Jan 18, 2022 at 04:54:51PM +0000, Sean Christopherson wrote:
> On Tue, Jan 18, 2022, Yang Zhong wrote:
> > Need sync KVM_CAP_XSAVE2 from linux header to here.
> >
> > Signed-off-by: Yang Zhong <yang.zhong@intel.com>
> > ---
> > tools/include/uapi/linux/kvm.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/include/uapi/linux/kvm.h b/tools/include/uapi/linux/kvm.h
> > index f066637ee206..63b96839186c 100644
> > --- a/tools/include/uapi/linux/kvm.h
> > +++ b/tools/include/uapi/linux/kvm.h
> > @@ -1131,7 +1131,7 @@ struct kvm_ppc_resize_hpt {
> > #define KVM_CAP_EXIT_ON_EMULATION_FAILURE 204
> > #define KVM_CAP_ARM_MTE 205
> > #define KVM_CAP_VM_MOVE_ENC_CONTEXT_FROM 206
> > -#define KVM_CAP_XSAVE2 207
> > +#define KVM_CAP_XSAVE2 208
>
> Any reason not to opportunistically sync the entire file? E.g. this diff looks
> rather confusing without pulling in KVM_CAP_VM_GPA_BITS (that consumes "207").
>
Thanks Sean, I checked this file history, Arnaldo Carvalho de Melo <acme@redhat.com>,
who always sync this header with kernel source, so maybe much better if he can do this.
Please ignore this patch and help review patch 2, thanks!
Yang
> >
> > #ifdef KVM_CAP_IRQ_ROUTING
> >
next prev parent reply other threads:[~2022-01-19 2:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 14:01 [PATCH 0/2] kvm selftest cleanup Yang Zhong
2022-01-18 14:01 ` [PATCH 1/2] kvm: selftests: Sync KVM_CAP_XSAVE2 from linux header Yang Zhong
2022-01-18 16:54 ` Sean Christopherson
2022-01-19 1:51 ` Yang Zhong [this message]
2022-01-18 14:01 ` [PATCH 2/2] kvm: selftests: Use tabs to replace spaces Yang Zhong
2022-01-19 18:35 ` [PATCH 0/2] kvm selftest cleanup Paolo Bonzini
2022-01-20 1:04 ` Yang Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220119015153.GA24086@yangzhon-Virtual \
--to=yang.zhong@intel.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).