From: Cathy Avery <cavery@redhat.com>
To: kvm@vger.kernel.org
Subject: [kvm-unit-tests PATCH] vmx: Fix EPT accessed and dirty flag test
Date: Fri, 21 Jan 2022 10:34:08 -0500 [thread overview]
Message-ID: <20220121153408.2332-1-cavery@redhat.com> (raw)
If ept_ad is not supported by the processor or has been
turned off via kvm module param, test_ept_eptp() will
incorrectly leave EPTP_AD_FLAG set in variable eptp
causing the following failures of subsequent
test_vmx_valid_controls calls:
FAIL: Enable-EPT enabled; reserved bits [11:7] 0: vmlaunch succeeds
FAIL: Enable-EPT enabled; reserved bits [63:N] 0: vmlaunch succeeds
Signed-off-by: Cathy Avery <cavery@redhat.com>
---
x86/vmx_tests.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c
index 3d57ed6..54f2aaa 100644
--- a/x86/vmx_tests.c
+++ b/x86/vmx_tests.c
@@ -4783,6 +4783,7 @@ static void test_ept_eptp(void)
eptp |= EPTP_AD_FLAG;
test_eptp_ad_bit(eptp, false);
+ eptp &= ~EPTP_AD_FLAG;
}
/*
--
2.31.1
next reply other threads:[~2022-01-21 15:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 15:34 Cathy Avery [this message]
2022-01-21 15:50 ` [kvm-unit-tests PATCH] vmx: Fix EPT accessed and dirty flag test Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220121153408.2332-1-cavery@redhat.com \
--to=cavery@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).